Kai S. K. Engelbart kske
3 Followers · 4 Following
  • Joined on 2020-08-15
Repositories
7
 Projects Packages Public Activity Watched Repositories
kske opened issue zdm/event-bus#11 2021-02-20 22:18:52 +01:00
Event Handler Exception Handling With Events
kske pushed to f/dead-event at zdm/event-bus 2021-02-20 22:12:01 +01:00
b2fe3a9d6c Log unhandled dead events
526899e887 Log unhandled dead events
Compare 2 commits »
kske commented on pull request zdm/event-bus#9 2021-02-20 22:08:58 +01:00
Add DeadEvent

I have ammended my original commit.

kske pushed to f/dead-event at zdm/event-bus 2021-02-20 22:08:41 +01:00
526899e887 Log unhandled dead events
1ef40fce18 Log unhandled dead events
Compare 2 commits »
kske commented on pull request zdm/event-bus#9 2021-02-20 22:07:50 +01:00
Add DeadEvent

I don't, but why unnecessarily obfuscate the type? The fact that this is a tree set is important here as it guarantees the event handler order, so the variable type might as well reflect this.

kske commented on pull request zdm/event-bus#9 2021-02-20 22:06:26 +01:00
Add DeadEvent

That's why I use the if statement. I could use a boolean flag instead, but the iterator logic should be more efficient and arguably more readable here.

kske commented on pull request zdm/event-bus#9 2021-02-20 22:05:34 +01:00
Add DeadEvent

I need the else (if) case here as well, but unfortunately this is not Python.

kske opened issue zdm/event-bus#10 2021-02-20 22:04:06 +01:00
Define Priority and Polymorphism at Listener Level
kske pushed to f/dead-event at zdm/event-bus 2021-02-20 21:52:27 +01:00
1ef40fce18 Log unhandled dead events
c8e38178bb Log unhandled dead events
Compare 2 commits »
kske deleted branch f/additional-warnings from zdm/event-bus 2021-02-20 21:46:13 +01:00
kske pushed to develop at zdm/event-bus 2021-02-20 21:46:09 +01:00
9379e6bb94 Merge pull request 'Additional Warnings in Event Bus Proc' (#8) from f/additional-warnings into develop
8a30493c52 Warn about unused event handler return values
b56f08e441 Warn about unnecessarily polymorphic event handlers
Compare 3 commits »
kske merged pull request zdm/event-bus#8 2021-02-20 21:46:08 +01:00
Additional Warnings in Event Bus Proc
kske closed issue zdm/event-bus#6 2021-02-20 21:46:08 +01:00
Reimplement Return Value Warning
kske created pull request zdm/event-bus#9 2021-02-20 21:45:00 +01:00
Add DeadEvent
kske pushed to f/dead-event at zdm/event-bus 2021-02-20 21:41:57 +01:00
c8e38178bb Log unhandled dead events
kske created pull request zdm/event-bus#8 2021-02-20 21:20:43 +01:00
Additional Warnings in Event Bus Proc
kske commented on issue zdm/event-bus#6 2021-02-20 21:20:27 +01:00
Reimplement Return Value Warning

The @SuppressWarnings thing isn't easily solvable as of yet, so any user that wants to remove the warning should just suppress it from their IDE.

kske pushed to f/dead-event at zdm/event-bus 2021-02-19 16:04:10 +01:00
0036dc4829 Add DeadEvent
kske pushed to f/additional-warnings at zdm/event-bus 2021-02-19 11:33:47 +01:00
8a30493c52 Warn about unused event handler return values
kske pushed to f/additional-warnings at zdm/event-bus 2021-02-19 11:29:35 +01:00
b56f08e441 Warn about unnecessarily polymorphic event handlers
4a5b94a9b7 Allow event handlers with non-void return type
ffc75d3615 Warn about unnecessarily polymorphic event handlers
b750fe866a Allow event handlers with non-void return type
Compare 4 commits »