Kai S. K. Engelbart kske
  • Joined on 2020-08-15
kske pushed to develop at zdm/event-bus 2021-02-17 08:21:50 +01:00
ff35e7f37d Fix several edge cases in EventProcessor
kske pushed to develop at zdm/event-bus 2021-02-15 21:01:30 +01:00
1dd9e05c38 Rename event-bus-ap to event-bus-proc
kske deleted branch f/new-annotations from zdm/event-bus 2021-02-15 20:38:25 +01:00
kske pushed to develop at zdm/event-bus 2021-02-15 20:38:19 +01:00
39c51c8953 Merge pull request 'Split @Event Parameters Into @Polymorphic and @Property, Remove Marker Interfaces' (#5) from f/new-annotations into develop
002180ed3b Remove EventListener and IEvent marker interfaces
cd2e7ad023 Rename Event#eventType to Event#value for more concise usage
9b1c708514 Replace priority with @Priority
3a6ebe9a19 Replace includeSubtypes with @Polymorphic
Compare 5 commits »
kske merged pull request zdm/event-bus#5 2021-02-15 20:38:19 +01:00
Split @Event Parameters Into @Polymorphic and @Property, Remove Marker Interfaces
kske pushed to f/new-annotations at zdm/event-bus 2021-02-15 20:35:13 +01:00
002180ed3b Remove EventListener and IEvent marker interfaces
be38c1fd02 Remove EventListener and IEvent marker interfaces
af3644b6b9 Remove EventListener and IEvent marker interfaces
Compare 3 commits »
kske pushed to f/new-annotations at zdm/event-bus 2021-02-15 20:33:51 +01:00
be38c1fd02 Remove EventListener and IEvent marker interfaces
kske commented on pull request zdm/event-bus#5 2021-02-15 20:33:01 +01:00
Split @Event Parameters Into @Polymorphic and @Property, Remove Marker Interfaces

Actually, yes I think so. Integer.compare calls Integer.valueOf two times, generating two objects in the process just to execute a statement similar to the one I wrote.

But, to your credit, I…

kske commented on pull request zdm/event-bus#5 2021-02-15 20:25:54 +01:00
Split @Event Parameters Into @Polymorphic and @Property, Remove Marker Interfaces

Because I got rid of the IEvent interface so that every object can be used as an event.

kske commented on pull request zdm/event-bus#5 2021-02-15 20:24:54 +01:00
Split @Event Parameters Into @Polymorphic and @Property, Remove Marker Interfaces

It would, but Objects.requireNonNull makes it immediately obvious to the caller that the parameter has to be non-null. I agree that it doesn't make much of the difference, but as it's handled like…

kske commented on pull request zdm/event-bus#5 2021-02-15 20:23:15 +01:00
Split @Event Parameters Into @Polymorphic and @Property, Remove Marker Interfaces

But isn't that what we want to achieve? A dedicated event listener would not necessarily be referenced from other classes apart from EventBus. Also, EventBus allows the deletion of event…

kske commented on pull request zdm/event-bus#5 2021-02-15 20:21:32 +01:00
Split @Event Parameters Into @Polymorphic and @Property, Remove Marker Interfaces

I coould, but this would mix the actual logic of the method with the logging and bloat up the line.

kske pushed to f/new-annotations at zdm/event-bus 2021-02-15 14:42:33 +01:00
af3644b6b9 Remove EventListener and IEvent marker interfaces
kske created pull request zdm/event-bus#5 2021-02-15 13:53:57 +01:00
Split @Event Parameters Into @Polymorphic and @Property
kske deleted branch f/annotation-processor from zdm/event-bus 2021-02-15 13:43:05 +01:00
kske pushed to develop at zdm/event-bus 2021-02-15 13:42:28 +01:00
603fe80df6 Merge pull request 'Restructure Project, Add Annotation Processor' (#4) from f/annotation-processor into develop
e040f6ab1b Simplify binding access calls in EventBus
ebc11555f6 Fix developer connection string in POM
955e2d82b4 Add Event Bus AP section to README
ab01845178 Refactor EventProcessor for improved readability
Compare 9 commits »
kske merged pull request zdm/event-bus#4 2021-02-15 13:42:28 +01:00
Restructure Project, Add Annotation Processor
kske pushed to f/new-annotations at zdm/event-bus 2021-02-15 13:41:52 +01:00
cd2e7ad023 Rename Event#eventType to Event#value for more concise usage
9b1c708514 Replace priority with @Priority
3a6ebe9a19 Replace includeSubtypes with @Polymorphic
kske pushed to f/annotation-processor at zdm/event-bus 2021-02-15 09:24:13 +01:00
e040f6ab1b Simplify binding access calls in EventBus
kske pushed to f/annotation-processor at zdm/event-bus 2021-02-15 08:25:04 +01:00
ebc11555f6 Fix developer connection string in POM