Kai S. K. Engelbart kske
3 Followers · 4 Following
  • Joined on 2020-08-15
Repositories
7
 Projects Packages Public Activity Watched Repositories
kske merged pull request zdm/undo-redo#2 2021-12-11 21:45:59 +01:00
Basic API Structure
kske pushed to develop at zdm/undo-redo 2021-12-11 21:45:59 +01:00
4b07626155 Merge pull request 'Basic API Structure' (#2) from f/basics into develop
a4695870c4 Fix core module name
23aa60e65e Move everything into the core package
93e177cc35 Changed LinkedList to ArrayList
4ef3c41251 Adapt Jenkinsfile to multi-module architecture
Compare 13 commits »
kske deleted branch f/basics from zdm/undo-redo 2021-12-11 21:45:59 +01:00
kske approved zdm/undo-redo#2 2021-12-11 18:23:17 +01:00
Basic API Structure
kske pushed to f/basics at zdm/undo-redo 2021-12-11 18:22:08 +01:00
a4695870c4 Fix core module name
kske pushed to f/basics at zdm/undo-redo 2021-12-11 18:18:42 +01:00
23aa60e65e Move everything into the core package
kske commented on pull request zdm/undo-redo#2 2021-12-11 18:13:11 +01:00
Basic API Structure

@DieGurke and me decided to use the array list for simplicity's sake.

kske opened issue zdm/undo-redo#3 2021-12-11 18:11:31 +01:00
JavaFX Integration
kske pushed to f/basics at zdm/undo-redo 2021-12-11 17:58:12 +01:00
4ef3c41251 Adapt Jenkinsfile to multi-module architecture
kske pushed to f/basics at zdm/undo-redo 2021-12-11 17:55:53 +01:00
c411eace81 Convert to multi-module project
kske pushed to f/basics at zdm/undo-redo 2021-12-11 14:11:18 +01:00
ee6015b353 Fix index handling in change manager
kske pushed to f/basics at zdm/undo-redo 2021-12-11 14:00:05 +01:00
2773d360fb Implement change manager unit tests
kske pushed to f/basics at zdm/undo-redo 2021-12-10 18:39:59 +01:00
bb7c1690b2 Add change manager unit test skeleton
kske commented on pull request zdm/undo-redo#2 2021-12-10 10:57:57 +01:00
Basic API Structure

I don't remember discussing this at length, but consider both approaches to be acceptable. I would have wrote the code myself like @DieGurke did because it is the straight-forward solution. If I…

kske commented on pull request zdm/undo-redo#2 2021-12-10 10:48:10 +01:00
Basic API Structure

For that to work, would the JavaFX-based proxy simply be a separate class, or would it have to reside in a separate module? I thought about having such a module with JavaFX-based extensions of our…

kske commented on pull request zdm/undo-redo#2 2021-12-10 10:45:53 +01:00
Basic API Structure

https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/ListIterator.html#add(E)

kske commented on pull request zdm/undo-redo#2 2021-12-09 18:35:16 +01:00
Basic API Structure

I think it is better to save a variable instead of saving a line.

kske commented on pull request zdm/undo-redo#2 2021-12-09 18:34:03 +01:00
Basic API Structure

I think we should use an iterator here. An array list wouldn't be nice either because of the continuous growth of the list.

kske commented on pull request zdm/undo-redo#2 2021-12-09 18:32:47 +01:00
Basic API Structure

Would it be possible to use the library without JavaFX in that case?

kske pushed to f/basics at zdm/undo-redo 2021-12-08 10:42:57 +01:00
dc74b78d20 Add Jenkinsfile