Applying suggestions from code review 2

This commit is contained in:
delvh 2020-06-14 16:11:46 +02:00
parent 2653ec5fee
commit 092caaef9f
2 changed files with 5 additions and 4 deletions

View File

@ -52,7 +52,6 @@ public final class Startup extends Application {
public void start(Stage stage) throws Exception { public void start(Stage stage) throws Exception {
try { try {
// Load the configuration from client.properties first // Load the configuration from client.properties first
logger.log(Level.INFO, "Envoy was started at " + new Date());
final Properties properties = new Properties(); final Properties properties = new Properties();
properties.load(Startup.class.getClassLoader().getResourceAsStream("client.properties")); properties.load(Startup.class.getClassLoader().getResourceAsStream("client.properties"));
config.load(properties); config.load(properties);
@ -76,6 +75,8 @@ public final class Startup extends Application {
EnvoyLog.setFileLevelBarrier(config.getFileLevelBarrier()); EnvoyLog.setFileLevelBarrier(config.getFileLevelBarrier());
EnvoyLog.setConsoleLevelBarrier(config.getConsoleLevelBarrier()); EnvoyLog.setConsoleLevelBarrier(config.getConsoleLevelBarrier());
logger.log(Level.INFO, "Envoy was started at " + new Date());
// Initialize the local database // Initialize the local database
if (config.isIgnoreLocalDB()) { if (config.isIgnoreLocalDB()) {
localDB = new TransientLocalDB(); localDB = new TransientLocalDB();

View File

@ -238,7 +238,7 @@ public final class ChatScene {
messageTextArea.positionCaret(MAX_MESSAGE_LENGTH); messageTextArea.positionCaret(MAX_MESSAGE_LENGTH);
messageTextArea.setScrollTop(Double.MAX_VALUE); messageTextArea.setScrollTop(Double.MAX_VALUE);
} }
designRemainingCharsLabel(); updateRemainingCharsLabel();
} }
/** /**
@ -246,7 +246,7 @@ public final class ChatScene {
* *
* @since Envoy Client v0.1-beta * @since Envoy Client v0.1-beta
*/ */
private void designRemainingCharsLabel() { private void updateRemainingCharsLabel() {
final int currentLength = messageTextArea.getText().length(); final int currentLength = messageTextArea.getText().length();
final int remainingLength = MAX_MESSAGE_LENGTH - currentLength; final int remainingLength = MAX_MESSAGE_LENGTH - currentLength;
remainingChars.setText(String.format("remaining chars: %d/%d", remainingLength, MAX_MESSAGE_LENGTH)); remainingChars.setText(String.format("remaining chars: %d/%d", remainingLength, MAX_MESSAGE_LENGTH));
@ -286,6 +286,6 @@ public final class ChatScene {
// Clear text field and disable post button // Clear text field and disable post button
messageTextArea.setText(""); messageTextArea.setText("");
postButton.setDisable(true); postButton.setDisable(true);
designRemainingCharsLabel(); updateRemainingCharsLabel();
} }
} }