From a457261ee5d1fe6cf1cd15830fc0cc2409978412 Mon Sep 17 00:00:00 2001
From: delvh <dev.lh@web.de>
Date: Fri, 10 Apr 2020 15:53:30 +0200
Subject: [PATCH] Improved Login security

---
 .project                                               |  4 ++--
 .../server/processors/LoginCredentialProcessor.java    | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/.project b/.project
index d6ba176..48ebc25 100755
--- a/.project
+++ b/.project
@@ -21,12 +21,12 @@
 			</arguments>
 		</buildCommand>
 		<buildCommand>
-			<name>org.eclipse.m2e.core.maven2Builder</name>
+			<name>org.hibernate.eclipse.console.hibernateBuilder</name>
 			<arguments>
 			</arguments>
 		</buildCommand>
 		<buildCommand>
-			<name>org.hibernate.eclipse.console.hibernateBuilder</name>
+			<name>org.eclipse.m2e.core.maven2Builder</name>
 			<arguments>
 			</arguments>
 		</buildCommand>
diff --git a/src/main/java/envoy/server/processors/LoginCredentialProcessor.java b/src/main/java/envoy/server/processors/LoginCredentialProcessor.java
index 3b4212e..5bc556f 100755
--- a/src/main/java/envoy/server/processors/LoginCredentialProcessor.java
+++ b/src/main/java/envoy/server/processors/LoginCredentialProcessor.java
@@ -93,21 +93,21 @@ public class LoginCredentialProcessor implements ObjectProcessor<LoginCredential
 
 			// Checking if user is already online
 			if (connectionManager.isOnline(user.getID())) {
-				writeProxy.write(socketID, new HandshakeRejectionEvent(HandshakeRejectionEvent.ALREADY_ONLINE));
+				writeProxy.write(socketID, new HandshakeRejectionEvent(HandshakeRejectionEvent.INTERNAL_ERROR));
 				return null;
 			}
 			// Evaluating the correctness of the password hash
 			if (!Arrays.equals(credentials.getPasswordHash(), user.getPasswordHash())) {
-				writeProxy.write(socketID, new HandshakeRejectionEvent(HandshakeRejectionEvent.WRONG_PASSWORD));
+				writeProxy.write(socketID, new HandshakeRejectionEvent(HandshakeRejectionEvent.WRONG_PASSWORD_OR_USER));
 				return null;
 			}
 			return user;
 		} catch (NoResultException e) {
 			// Checking if user exists
-			writeProxy.write(socketID, new HandshakeRejectionEvent(HandshakeRejectionEvent.USER_DOES_NOT_EXIST));
+			writeProxy.write(socketID, new HandshakeRejectionEvent(HandshakeRejectionEvent.INTERNAL_ERROR));
 		} catch (InputMismatchException e) {
 			// Checking if the given password hash is correct
-			writeProxy.write(socketID, new HandshakeRejectionEvent(HandshakeRejectionEvent.WRONG_PASSWORD));
+			writeProxy.write(socketID, new HandshakeRejectionEvent(HandshakeRejectionEvent.WRONG_PASSWORD_OR_USER));
 		}
 		return null;
 	}
@@ -127,7 +127,7 @@ public class LoginCredentialProcessor implements ObjectProcessor<LoginCredential
 			// Checking that no user already has this identifier
 			PersistenceManager.getInstance().getUserByName(credentials.getIdentifier());
 			// this code only gets executed if this user already exists
-			writeProxy.write(socketID, new HandshakeRejectionEvent(HandshakeRejectionEvent.USER_EXISTS_ALREADY));
+			writeProxy.write(socketID, new HandshakeRejectionEvent(HandshakeRejectionEvent.INTERNAL_ERROR));
 			return null;
 		} catch (NoResultException e) {
 			// Creation of a new user