zdm/envoy
zdm/envoy
Archived
3
Fork 0
Code Issues 22 Pull Requests Releases 1 Wiki Activity

Merge pull request #162 from informatik-ag-ngl/b/unnecessary_IOException

Browse Source 
Removed unnecessary IOException in IconUtil
This commit is contained in:
Kai S. K. Engelbart 2020-06-27 09:12:18 +00:00 committed by GitHub
commit f5526aad43
3 changed files with 14 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/main/java/envoy/client/ui/IconUtil.java
View File

@ -1,6 +1,5 @@
package envoy.client.ui; package envoy.client.ui;
import java.io.IOException;
import java.util.EnumMap; import java.util.EnumMap;
import java.util.EnumSet; import java.util.EnumSet;
@ -26,10 +25,9 @@ public class IconUtil {
* *
* @param path the path to the icon inside the resource folder * @param path the path to the icon inside the resource folder
* @return the icon * @return the icon
* @throws IOException if the loading process failed
* @since Envoy Client v0.1-beta * @since Envoy Client v0.1-beta
*/ */
public static Image load(String path) throws IOException { return new Image(IconUtil.class.getResource(path).toExternalForm()); } public static Image load(String path) { return new Image(IconUtil.class.getResource(path).toExternalForm()); }
/** /**
* Loads an icon from the resource folder and scales it to a given size. * Loads an icon from the resource folder and scales it to a given size.
@ -37,10 +35,9 @@ public class IconUtil {
* @param path the path to the icon inside the resource folder * @param path the path to the icon inside the resource folder
* @param size the size to scale the icon to * @param size the size to scale the icon to
* @return the scaled icon * @return the scaled icon
* @throws IOException if the loading process failed
* @since Envoy Client v0.1-beta * @since Envoy Client v0.1-beta
*/ */
public static Image load(String path, int size) throws IOException { public static Image load(String path, int size) {
return new Image(IconUtil.class.getResource(path).toExternalForm(), size, size, true, true); return new Image(IconUtil.class.getResource(path).toExternalForm(), size, size, true, true);
} }
@ -56,13 +53,12 @@ public class IconUtil {
* @param size the size to scale the icons to * @param size the size to scale the icons to
* @return a map containing the loaded icons with the corresponding enum * @return a map containing the loaded icons with the corresponding enum
* constants as keys * constants as keys
* @throws IOException if the loading process failed
* @since Envoy Client v0.1-beta * @since Envoy Client v0.1-beta
*/ */
public static <T extends Enum<T>> EnumMap<T, Image> loadByEnum(Class<T> enumClass, int size) throws IOException { public static <T extends Enum<T>> EnumMap<T, Image> loadByEnum(Class<T> enumClass, int size) {
var icons = new EnumMap<T, Image>(enumClass); final var icons = new EnumMap<T, Image>(enumClass);
var path = "/icons/" + enumClass.getSimpleName().toLowerCase() + "/"; final var path = "/icons/" + enumClass.getSimpleName().toLowerCase() + "/";
for (var e : EnumSet.allOf(enumClass)) for (final var e : EnumSet.allOf(enumClass))
icons.put(e, load(path + e.toString().toLowerCase() + ".png", size)); icons.put(e, load(path + e.toString().toLowerCase() + ".png", size));
return icons; return icons;
} }

16
src/main/java/envoy/client/ui/MessageListCell.java
View File

@ -1,9 +1,7 @@
package envoy.client.ui; package envoy.client.ui;
import java.io.IOException;
import java.time.format.DateTimeFormatter; import java.time.format.DateTimeFormatter;
import java.util.Map; import java.util.Map;
import java.util.logging.Level;
import javafx.geometry.Insets; import javafx.geometry.Insets;
import javafx.scene.control.Label; import javafx.scene.control.Label;
@ -15,7 +13,6 @@ import javafx.scene.layout.VBox;
import envoy.data.Message; import envoy.data.Message;
import envoy.data.Message.MessageStatus; import envoy.data.Message.MessageStatus;
import envoy.data.User; import envoy.data.User;
import envoy.util.EnvoyLog;
/** /**
* Displays a single message inside the message list. * Displays a single message inside the message list.
@ -29,18 +26,9 @@ import envoy.util.EnvoyLog;
*/ */
public class MessageListCell extends ListCell<Message> { public class MessageListCell extends ListCell<Message> {
private static final DateTimeFormatter dateFormat = DateTimeFormatter.ofPattern("dd.MM.yyyy HH:mm");
private static Map<MessageStatus, Image> statusImages;
private static User client; private static User client;
private static final DateTimeFormatter dateFormat = DateTimeFormatter.ofPattern("dd.MM.yyyy HH:mm");
static { private static final Map<MessageStatus, Image> statusImages = IconUtil.loadByEnum(MessageStatus.class, 16);
try {
statusImages = IconUtil.loadByEnum(MessageStatus.class, 16);
} catch (final IOException e) {
e.printStackTrace();
EnvoyLog.getLogger(MessageListCell.class).log(Level.WARNING, "could not load status icons: ", e);
}
}
/** /**
* Displays the text, the data of creation and the status of a message. * Displays the text, the data of creation and the status of a message.

4
src/main/java/envoy/client/ui/controller/ChatScene.java
View File

@ -89,11 +89,7 @@ public final class ChatScene {
messageList.setCellFactory(listView -> new MessageListCell()); messageList.setCellFactory(listView -> new MessageListCell());
userList.setCellFactory(listView -> new ContactListCell()); userList.setCellFactory(listView -> new ContactListCell());
try {
settingsButton.setGraphic(new ImageView(IconUtil.load("/icons/settings.png", 16))); settingsButton.setGraphic(new ImageView(IconUtil.load("/icons/settings.png", 16)));
} catch (final IOException e2) {
logger.log(Level.WARNING, "Could not load settings icon", e2);
}
// Listen to received messages // Listen to received messages
eventBus.register(MessageCreationEvent.class, e -> { eventBus.register(MessageCreationEvent.class, e -> {