Display Current User Status and Unread Message Amount in Status Tray Icon #103

kske · 2020-10-18T16:47:07+02:00

kske commented

2020-10-18 16:47:07 +02:00

Fixes #12

kske added this to the v0.3-beta milestone 2020-10-18 16:47:07 +02:00

kske added the

M

label 2020-10-18 16:47:07 +02:00

kske self-assigned this 2020-10-18 16:47:07 +02:00

kske requested review from delvh 2020-10-18 16:47:14 +02:00

kske requested review from mpk 2020-10-18 16:47:15 +02:00

kske commented

2020-10-18 16:47:52 +02:00

@DieGurke please verify that this works properly on Microsoft Windows.

delvh approved these changes 2020-10-18 16:53:00 +02:00

delvh left a comment

👍

mpk requested changes 2020-10-20 18:41:44 +02:00

mpk left a comment

First I don't really like the fact that the status tray icon is only displayed if hide on close is enabled. It should rather be enabled at all times.

Status display works fine although I don't like the visual appeal as you have to know what is is displaying. (But is ok for now)
Whats not ok is the unread messages displaying! First the little square where it is displayed at the moment is way to small as it just cuts of half of the number on Linux Arch and doesn't even display anything on Microsoft Windows.
I suggest displaying the unread messages amount when the status tray icon is clicked just like the operations you can perform.

First I don't really like the fact that the status tray icon is only displayed if hide on close is enabled. It should rather be enabled at all times. * Status display works fine although I don't like the visual appeal as you have to know what is is displaying. (But is ok for now) * Whats not ok is the unread messages displaying! First the little square where it is displayed at the moment is way to small as it just cuts of half of the number on Linux Arch and doesn't even display anything on Microsoft Windows. I suggest displaying the unread messages amount when the status tray icon is clicked just like the operations you can perform.

mpk commented

2020-10-20 18:48:53 +02:00

Additionally I noticed a severe bug: if you have unread messages and close the clien't down, the next time you open it again you have the double amount of unread messeges displayed as the client received them twice each. (The number in the status tray icon is more or less comlpetely random after the second start it seems). Please investigate on this!
See #104

Additionally I noticed a severe bug: if you have unread messages and close the clien't down, the next time you open it again you have the double amount of unread messeges displayed as the client received them twice each. (The number in the status tray icon is more or less comlpetely random after the second start it seems). Please investigate on this! See #104

👀 1

kske referenced this pull request

2020-10-20 19:17:21 +02:00

Doubling Messages Bug #104

kske commented

2020-10-20 19:23:21 +02:00

@DieGurke the issue on Arch Linux arises from the fact that KDE's status tray API has evolved from what AWT's StatusTray has been designed for (Java 5).

The StatusTrayIcon runs using a legacy API which doesn't seem to handle scaling the same way Eclipse or the rest of Envoy does.

Apart from writing platform-specific C code using JNI / JNA, we cannot do much about this, however @delvh pointed out to me that DPI scaling can actually work without the explicit setting of environment variables.

I will look into the issue you describe for Microsoft Windows, however.

@DieGurke the issue on Arch Linux arises from the fact that KDE's status tray API has evolved from what AWT's `StatusTray` has been designed for (Java 5). The `StatusTrayIcon` runs using a [legacy API ](https://invent.kde.org/plasma/plasma-workspace/-/blob/master/xembed-sni-proxy/Readme.md) which doesn't seem to handle scaling the same way Eclipse or the rest of Envoy does. Apart from writing platform-specific C code using JNI / JNA, we cannot do much about this, however @delvh pointed out to me that DPI scaling can actually work without the explicit setting of environment variables. I will look into the issue you describe for Microsoft Windows, however.

delvh commented

2020-10-20 20:07:00 +02:00

@DieGurke @kske I guess I know where this bug is originating from: IIRC, loadUserData gets called twice when using token authentication. Each time, the chats get reloaded. And as the totalUnreadAmount always gets updated when readObject gets called, it'll show twice the amount of messages. That is my semi-educated guess.

@DieGurke @kske I guess I know where this bug is originating from: IIRC, `loadUserData` gets called twice when using token authentication. Each time, the chats get reloaded. And as the `totalUnreadAmount` always gets updated when `readObject` gets called, it'll show twice the amount of messages. That is my semi-educated guess.

delvh commented

2020-10-20 20:08:57 +02:00

First I don’t really like the fact that the status tray icon is only displayed if hide on close is enabled. It should rather be enabled at all times.

@DieGurke as long as the default value stays false, I have nothing against it.

> First I don’t really like the fact that the status tray icon is only displayed if hide on close is enabled. It should rather be enabled at all times. @DieGurke as long as the default value stays `false`, I have nothing against it.

delvh referenced this pull request

2020-10-20 20:10:18 +02:00

Doubling Messages Bug #104

kske requested review from mpk 2020-10-22 14:57:34 +02:00

mpk approved these changes 2020-10-23 17:19:26 +02:00

mpk left a comment

Basst