Receiving an Illegal Message ID Does Not Close the Transaction #16

Closed
opened 2020-09-06 11:25:39 +02:00 by mpk · 0 comments

When the server receives a message with an id that has already been assigned, it does handle it accordingly.
However, the current transaction is not getting closed resulting in a data blockage: No more objects can be written to the database.
This is malevolent in every way possible as it allows to crash the server by doing four simple things:

  1. Start a client
  2. Send a message
  3. Force close client (SIGKILL 15)
  4. Reopen and send another message
  5. Enjoy!

In order to ensure the continuation of the server, somehow the transaction should be closed. The easiest approach to this would be a try-finally block inside the PersistenceManager, however many other ways are also possible.

grafik
right side of the exception:
grafik

When the server receives a message with an id that has already been assigned, it does handle it accordingly. However, the current transaction is not getting closed resulting in a data blockage: No more objects can be written to the database. This is malevolent in every way possible as it allows to crash the server by doing four simple things: 1. Start a client 2. Send a message 3. Force close client (`SIGKILL 15`) 4. Reopen and send another message 5. Enjoy! In order to ensure the continuation of the server, somehow the transaction should be closed. The easiest approach to this would be a `try-finally` block inside the `PersistenceManager`, however many other ways are also possible. ![grafik](/attachments/7766fbbd-2950-4a79-b2ac-651c90ff0447) right side of the exception: ![grafik](/attachments/e3489a87-4dac-43a3-b0e1-ca98b1a2318a)
mpk added this to the v0.2-beta milestone 2020-09-06 11:25:39 +02:00
mpk added the
bug
S
server
labels 2020-09-06 11:25:39 +02:00
kske was assigned by mpk 2020-09-06 11:25:39 +02:00
kske changed title from Receiving an Illegal Message Id Does Not Close the Transaction to Receiving an Illegal Message ID Does Not Close the Transaction 2020-09-06 11:27:57 +02:00
delvh closed this issue 2020-09-22 17:02:51 +02:00
This repo is archived. You cannot comment on issues.
There is no content yet.