Receiving an Illegal Message ID Does Not Close the Transaction #16

New Issue

mpk · 2020-09-06T11:25:39+02:00

mpk commented

2020-09-06 11:25:39 +02:00

When the server receives a message with an id that has already been assigned, it does handle it accordingly.
However, the current transaction is not getting closed resulting in a data blockage: No more objects can be written to the database.
This is malevolent in every way possible as it allows to crash the server by doing four simple things:

Start a client
Send a message
Force close client (SIGKILL 15)
Reopen and send another message
Enjoy!

In order to ensure the continuation of the server, somehow the transaction should be closed. The easiest approach to this would be a try-finally block inside the PersistenceManager, however many other ways are also possible.

right side of the exception:

When the server receives a message with an id that has already been assigned, it does handle it accordingly. However, the current transaction is not getting closed resulting in a data blockage: No more objects can be written to the database. This is malevolent in every way possible as it allows to crash the server by doing four simple things: 1. Start a client 2. Send a message 3. Force close client (`SIGKILL 15`) 4. Reopen and send another message 5. Enjoy! In order to ensure the continuation of the server, somehow the transaction should be closed. The easiest approach to this would be a `try-finally` block inside the `PersistenceManager`, however many other ways are also possible. ![grafik](/attachments/7766fbbd-2950-4a79-b2ac-651c90ff0447) right side of the exception: ![grafik](/attachments/e3489a87-4dac-43a3-b0e1-ca98b1a2318a)

grafik.png

94 KiB

grafik.png

42 KiB

mpk added this to the v0.2-beta milestone 2020-09-06 11:25:39 +02:00

mpk added the

bug

S

server

labels 2020-09-06 11:25:39 +02:00

kske was assigned by mpk

2020-09-06 11:25:39 +02:00

kske changed title from ~~Receiving an Illegal Message Id Does Not Close the Transaction~~ to Receiving an Illegal Message ID Does Not Close the Transaction

2020-09-06 11:27:57 +02:00

delvh referenced this issue from a commit

2020-09-22 16:59:54 +02:00

Fixed transaction not getting closed Fixes #16

delvh referenced a pull request that will close this issue

2020-09-22 17:00:29 +02:00

Fixed Transactions not Getting Closed on the Server #42

delvh referenced this issue from a commit

2020-09-22 17:02:51 +02:00

Fixed Transactions not Getting Closed on the Server (#42) Fixes #16 Reviewed-on: https://git.kske.dev/zdm/envoy/pulls/42 Reviewed-by: kske <kai@kske.dev>

delvh closed this issue

2020-09-22 17:02:51 +02:00