Refactoring #21

New Issue

delvh · 2020-09-16T14:59:10+02:00

delvh commented

2020-09-16 14:59:10 +02:00

In @kske 's opinion, many UI classes fulfill purposes that are more than just displaying the UI (especially ChatScene). As this class has way too many lines in his opinion (~750), it should be shortened.

So, how can we achieve clean code?

UI classes should only contain UI related code -> event methods should NOT contain the logic of changing something in the LocalDB.
Some parts of the voice recording process used in ChatScene can be outsourced to a separate component, i.e. the AudioRecorder.
(LocalDB could store internally an ObservableList, whose underlying list is serialized. When this list changes, ChatScene might automatically be updated)

In @kske 's opinion, many UI classes fulfill purposes that are more than just displaying the UI (especially `ChatScene`). As this class has way too many lines in his opinion (~750), it should be shortened. So, how can we achieve **clean code**? 1. UI classes should only contain UI related code -> event methods should **NOT** contain the logic of changing something in the `LocalDB`. 2. Some parts of the voice recording process used in ChatScene can be outsourced to a separate component, i.e. the `AudioRecorder`. 3. (LocalDB could store internally an `ObservableList`, whose underlying list is serialized. When this list changes, `ChatScene` might automatically be updated)

delvh added this to the v0.2-beta milestone 2020-09-16 14:59:10 +02:00

delvh added the

client

M

labels 2020-09-16 14:59:10 +02:00

mpk was assigned by delvh

2020-09-16 14:59:10 +02:00

delvh self-assigned this 2020-09-16 14:59:10 +02:00

delvh started working 2020-09-16 15:05:32 +02:00

delvh added the due date 2020-10-01

2020-09-16 15:06:13 +02:00

delvh added a new dependency 2020-09-16 15:13:18 +02:00