zdm/envoy
zdm/envoy
Archived
3
Fork 0
Code Issues 22 Pull Requests Releases 1 Wiki Activity

Add Ability to Logout #50

Merged
kske merged 7 commits from f/logout into develop 2020-09-27 15:48:13 +02:00
Conversation 0 Commits 7 Files Changed 18 +378 -55
delvh commented 2020-09-25 22:02:51 +02:00
Owner
Copy Link

Additionally added keyboard shortcuts and system commands for logout, exit and switching to the settings scene

Additionally added keyboard shortcuts and system commands for logout, exit and switching to the settings scene
delvh added this to the v0.2-beta milestone 2020-09-25 22:02:51 +02:00
delvh added the
client
L
 labels 2020-09-25 22:02:51 +02:00
delvh self-assigned this 2020-09-25 22:02:51 +02:00
delvh requested review from mpk 2020-09-25 22:04:02 +02:00
delvh requested review from kske 2020-09-25 22:04:03 +02:00
kske requested changes 2020-09-26 18:23:36 +02:00
kske left a comment
Owner

Looks good to me, please fix the cosmetics though 😆

Looks good to me, please fix the cosmetics though 😆
client/src/main/java/envoy/client/data/LocalDB.java Outdated
@ -40,6 +40,10 @@ public final class LocalDB implements EventListener {
private CacheMap cacheMap = new CacheMap();
private String authToken;
// auto save Timer
kske commented 2020-09-26 18:15:45 +02:00
Owner

This should be // Auto save time.

This should be `// Auto save time`.
delvh commented 2020-09-26 21:29:10 +02:00
Author
Owner

you mean // Auto save timer?

you mean `// Auto save timer`?
client/src/main/java/envoy/client/data/LocalDB.java Outdated
@ -170,1 +174,3 @@
new Timer("LocalDB Autosave", true).schedule(new TimerTask() {
if (autoSaveRestart) {
// A logout happened so the timer should be restarted
kske commented 2020-09-26 18:15:17 +02:00
Owner

Maybe move the comment above the if statement.

Maybe move the comment above the `if` statement.
delvh marked this conversation as resolved
client/src/main/java/envoy/client/data/LocalDB.java Outdated
@ -215,0 +229,4 @@
* @since Envoy Client v0.2-beta
*/
@Event(eventType = Logout.class, priority = 100)
public void onLogout() {
kske commented 2020-09-26 18:14:39 +02:00
Owner

Why is this public?

Why is this public?
delvh marked this conversation as resolved
client/src/main/java/envoy/client/data/LocalDB.java Outdated
@ -215,0 +238,4 @@
authToken = null;
chats.clear();
lastSync = Instant.EPOCH;
cacheMap.getMap().forEach((key, cache) -> cache.clear());
kske commented 2020-09-26 18:16:56 +02:00
Owner

Please remove the comment and add a clearing method to CacheMap.

Please remove the comment and add a clearing method to `CacheMap`.
delvh marked this conversation as resolved
client/src/main/java/envoy/client/event/Logout.java Outdated
@ -0,0 +5,4 @@
/**
* Indicates that a logout has been requested.
*
* @author leon
kske commented 2020-09-26 18:18:30 +02:00
Owner

Fix your @author tag.

Fix your `@author` tag.
delvh marked this conversation as resolved
client/src/main/java/envoy/client/helper/AlertHelper.java Outdated
@ -0,0 +10,4 @@
* @author Leon Hofmeister
* @since Envoy Client v0.2-beta
*/
public class AlertHelper {
kske commented 2020-09-26 18:18:53 +02:00
Owner

Make this final.

Make this `final`.
delvh marked this conversation as resolved
client/src/main/java/envoy/client/helper/ShutdownHelper.java Outdated
@ -0,0 +13,4 @@
import dev.kske.eventbus.EventBus;
/**
* Contains methods that have a direct impact on the user.
kske commented 2020-09-26 18:19:59 +02:00
Owner

What on earth does that even mean?

What on earth does that even mean?
delvh commented 2020-09-26 21:36:19 +02:00
Author
Owner

Changed it now.
If you don't like it, suggest a better alternative.
I cannot think of one.

Changed it now. If you don't like it, suggest a better alternative. I cannot think of one.
client/src/main/java/envoy/client/helper/ShutdownHelper.java Outdated
@ -0,0 +18,4 @@
* @author Leon Hofmeister
* @since Envoy Client v0.2-beta
*/
public class ShutdownHelper {
kske commented 2020-09-26 18:20:12 +02:00
Owner

Make this final.

Make this `final`.
delvh marked this conversation as resolved
delvh requested review from kske 2020-09-26 21:38:49 +02:00
kske approved these changes 2020-09-27 15:48:00 +02:00
kske merged commit c7ee545ee2 into develop 2020-09-27 15:48:12 +02:00
kske deleted branch f/logout 2020-09-27 15:48:19 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
mpk
kske
Labels
Clear labels   
client

Envoy Client

  
server

Envoy Server

  
user made

This issue has been created through Envoy

  
L

Branches where 300 < X <= 600 lines are added and more than one work day is needed

  
M

Branches where 100 < X <=300 lines are added

  
S

Branches where X <= 100 lines are added or less than 30 minutes are needed

  
XL

Branch where X > 600 lines are added and more than two work days are needed

  
bug

Something is not working

  
bugfix

Fixes a bug

  
discussion

This has to be discussed

  
documentation

Related to documentation

  
feature

Introduces a new feature

  
maintenance

Related to project maintenance

  
postponed

Won't be done in the immediate future

  
refactoring

Refactoring code or architectures

  
wontfix

Will not be fixed in this state of development

No Label
client
server
user made
L
M
S
XL
bug
bugfix
discussion
documentation
feature
maintenance
postponed
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.2-beta
Assignees
Clear assignees
No Assignees
delvh
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: zdm/envoy#50
No description provided.
Delete Branch "f/logout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?