zdm/envoy
zdm/envoy
Archived
3
Fork 0
Code Issues 22 Pull Requests Releases 1 Wiki Activity

Add Local Deletion of Messages Also for Messages You did not Send #80

Merged
delvh merged 2 commits from f/delete-messages-locally into develop 2020-10-05 18:52:06 +02:00
Conversation 3 Commits 2 Files Changed 1 +4 -6
delvh commented 2020-10-04 14:07:57 +02:00
Owner
Copy Link
No description provided.
delvh added this to the v0.3-beta milestone 2020-10-04 14:07:57 +02:00
delvh added the
S
client
 labels 2020-10-04 14:07:57 +02:00
delvh self-assigned this 2020-10-04 14:07:57 +02:00
kske approved these changes 2020-10-04 20:04:39 +02:00
kske left a comment
Owner

What brought you to this decision?

I think it's a good idea, however this doesn't seem to be unanimously agreed upon, for WhatsApp permitting it while Skype doesn't.

What brought you to this decision? I think it's a good idea, however this doesn't seem to be unanimously agreed upon, for WhatsApp permitting it while Skype doesn't.
kske requested review from mpk 2020-10-04 21:23:24 +02:00
delvh commented 2020-10-04 21:58:34 +02:00
Author
Owner
Copy Link

@kske: Well, the fact that normally I'd also want the opportunity to delete messages from others, if I don't want to see them. But that of course needs to be limited to local mode.
I already have a fair idea on how the code inside MessageControl will look like once the LocalDB proplem has been solved...

@kske: Well, the fact that normally I'd also want the opportunity to delete messages from others, if I don't want to see them. But that of course needs to be limited to local mode. I already have a fair idea on how the code inside `MessageControl` will look like once the `LocalDB` proplem has been solved...
mpk approved these changes 2020-10-05 16:42:39 +02:00
mpk left a comment
Owner

Good

Good
delvh merged commit fb1147f939 into develop 2020-10-05 18:52:05 +02:00
kske deleted branch f/delete-messages-locally 2020-10-05 19:21:00 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
kske
mpk
Labels
Clear labels
client
Envoy Client
server
Envoy Server
user made
This issue has been created through Envoy
L
Branches where 300 < X <= 600 lines are added and more than one work day is needed
M
Branches where 100 < X <=300 lines are added
S
Branches where X <= 100 lines are added or less than 30 minutes are needed
XL
Branch where X > 600 lines are added and more than two work days are needed
bug
Something is not working
bugfix
Fixes a bug
discussion
This has to be discussed
documentation
Related to documentation
feature
Introduces a new feature
maintenance
Related to project maintenance
postponed
Won't be done in the immediate future
refactoring
Refactoring code or architectures
wontfix
Will not be fixed in this state of development
No Label
client
S
Milestone
No items
No Milestone v0.3-beta
Assignees
Clear assignees
No Assignees delvh
3 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zdm/envoy#80
No description provided.
Delete Branch "f/delete-messages-locally"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?