Make PersistenceManager Less Error Prone #83

delvh · 2020-10-06T12:15:43+02:00

delvh commented

2020-10-06 12:15:43 +02:00

Reduced the amount of code used as a bproduct.

delvh added this to the v0.3-beta milestone 2020-10-06 12:15:43 +02:00

delvh added the

bug

S

server

labels 2020-10-06 12:15:43 +02:00

delvh self-assigned this 2020-10-06 12:15:43 +02:00

delvh commented

2020-10-06 12:27:05 +02:00

I really like it when we have real @kske commits...
Adding functionality by removing code is always fun 😆

I really like it when we have real @kske commits... Adding functionality by removing code is always fun 😆

delvh requested review from mpk 2020-10-06 12:33:15 +02:00

delvh requested review from kske 2020-10-06 12:33:18 +02:00

kske approved these changes 2020-10-06 12:58:41 +02:00

kske left a comment

Yes indeed, this is very elegant 👍

delvh changed title from ~~Made PersistenceManager Less Error Prone~~ to Make PersistenceManager Less Error Prone

2020-10-06 16:49:37 +02:00

mpk approved these changes 2020-10-07 21:20:53 +02:00

mpk left a comment

This looks very well thought out and elegant. Props to you!

delvh referenced this issue from a commit

2020-10-07 22:13:42 +02:00

Make PersistenceManager Less Error Prone (#83) Reviewed-on: https://git.kske.dev/zdm/envoy/pulls/83 Reviewed-by: kske <kai@kske.dev> Reviewed-by: DieGurke <maxi@kske.dev>

delvh merged commit f2eb89d469 into develop

2020-10-07 22:13:42 +02:00

delvh deleted branch b/crashing-server-with-invalid-objects

2020-10-07 22:13:56 +02:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

No Milestone

No Assignees

3 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: zdm/envoy#83