zdm/event-bus
zdm/event-bus
3
Fork 0
Code Issues 2 Pull Requests Releases 8 Wiki Activity

Pass errors caused during system event dispatch to caller

Browse Source 
When an error is caused during the dispatch of a system event, a warning
has been logged instead instead of rethrowing the error. This has been
fixed.

This enables failing a JUnit test when an exception event handler is
invoked.
This commit is contained in:
Kai S. K. Engelbart 2021-07-07 22:06:07 +02:00
parent b758f4cef1
commit 6eebd3c121
Signed by: kske
GPG Key ID: 8BEB13EC5DF7EF13
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
event-bus-core/src/main/java/dev/kske/eventbus/core/EventBus.java
View File

@ -94,14 +94,14 @@ public final class EventBus {
try { try {
handlers.next().execute(event); handlers.next().execute(event);
} catch (InvocationTargetException e) { } catch (InvocationTargetException e) {
if (event instanceof DeadEvent || event instanceof ExceptionEvent) if (e.getCause() instanceof Error)
// Warn about system event not being handled
logger.log(Level.WARNING, event + " not handled due to exception", e);
else if (e.getCause() instanceof Error)
// Transparently pass error to the caller // Transparently pass error to the caller
throw (Error) e.getCause(); throw (Error) e.getCause();
else if (event instanceof DeadEvent || event instanceof ExceptionEvent)
// Warn about system event not being handled
logger.log(Level.WARNING, event + " not handled due to exception", e);
else else
// Dispatch exception event // Dispatch exception event