zdm/event-bus
zdm/event-bus
3
Fork 0
Code Issues 2 Pull Requests Releases 8 Wiki Activity

Warn about unnecessarily polymorphic event handlers

Browse Source 
When Event Bus Proc detects a handler for a final type that uses the
@Polymorphic annotation, it issues a warning.
This commit is contained in:
Kai S. K. Engelbart 2021-02-18 22:18:13 +01:00
parent 4a5b94a9b7
commit b56f08e441
Signed by: kske
GPG Key ID: 8BEB13EC5DF7EF13
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
event-bus-proc/src/main/java/dev/kske/eventbus/proc/EventProcessor.java
View File

@ -80,14 +80,20 @@ public class EventProcessor extends AbstractProcessor {
} }
} }
// Check for handlers for abstract types that aren't polymorphic // Detect missing or useless @Polymorphic
boolean polymorphic = eventHandler.getAnnotation(Polymorphic.class) != null;
Element eventElement = ((DeclaredType) eventType).asElement(); Element eventElement = ((DeclaredType) eventType).asElement();
if (eventHandler.getAnnotation(Polymorphic.class) == null
&& (eventElement.getKind() == ElementKind.INTERFACE // Check for handlers for abstract types that aren't polymorphic
|| eventElement.getModifiers().contains(Modifier.ABSTRACT))) { if (!polymorphic && (eventElement.getKind() == ElementKind.INTERFACE
|| eventElement.getModifiers().contains(Modifier.ABSTRACT)))
warning(eventHandler, warning(eventHandler,
"Parameter should be instantiable or handler should use @Polymorphic"); "Parameter should be instantiable or handler should use @Polymorphic");
}
// Check for handlers for final types that are polymorphic
else if (polymorphic && eventElement.getModifiers().contains(Modifier.FINAL))
warning(eventHandler,
"@Polymorphic should be removed as parameter cannot be subclassed");
} }
} }