zdm/event-bus
zdm/event-bus
3
Fork 0
Code Issues 2 Pull Requests Releases 8 Wiki Activity

Add double checked synchronization to EventBus instance initializer

Browse Source
This commit is contained in:
Kai S. K. Engelbart 2020-09-24 17:41:08 +02:00
parent 603a838640
commit dbb816c6cb
Signed by: kske
GPG Key ID: 8BEB13EC5DF7EF13
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/main/java/dev/kske/eventbus/EventBus.java
View File

@ -19,7 +19,7 @@ import java.util.concurrent.ConcurrentHashMap;
*/ */
public final class EventBus { public final class EventBus {
private static EventBus singletonInstance; private static volatile EventBus singletonInstance;
private static final Logger logger = System.getLogger(EventBus.class.getName()); private static final Logger logger = System.getLogger(EventBus.class.getName());
@ -30,11 +30,15 @@ public final class EventBus {
* @since 0.0.2 * @since 0.0.2
*/ */
public static EventBus getInstance() { public static EventBus getInstance() {
if (singletonInstance == null) { EventBus instance = singletonInstance;
logger.log(Level.DEBUG, "Initializing singleton event bus instance"); if (instance == null)
singletonInstance = new EventBus(); synchronized (EventBus.class) {
} if ((instance = singletonInstance) == null) {
return singletonInstance; logger.log(Level.DEBUG, "Initializing singleton event bus instance");
instance = singletonInstance = new EventBus();
}
}
return instance;
} }
private final Map<Class<? extends IEvent>, TreeSet<EventHandler>> bindings private final Map<Class<? extends IEvent>, TreeSet<EventHandler>> bindings