Initialize the Default Event Bus Statically #23

kske · 2021-10-15T08:28:51+02:00

kske commented

2021-10-15 08:28:51 +02:00

The previous method that used double checked synchronization offers little performance benefits over a plain static initialization.

Reported-by @harkle-the-cake

The previous method that used double checked synchronization offers little performance benefits over a plain static initialization. Reported-by @harkle-the-cake

kske added the

enhancement

label 2021-10-15 08:28:51 +02:00

kske self-assigned this 2021-10-15 08:28:51 +02:00

kske requested review from delvh 2021-10-15 08:28:55 +02:00

delvh approved these changes 2021-10-15 18:45:39 +02:00

event-bus-core/src/main/java/dev/kske/eventbus/core/EventBus.java Outdated

						
				@@ -53,3 +53,3 @@

					public static final int DEFAULT_PRIORITY = 100;

					private static volatile EventBus singletonInstance;

					private static EventBus singletonInstance = new EventBus();

delvh commented

2021-10-15 18:45:13 +02:00

final

`final`

kske marked this conversation as resolved

kske force-pushed f/static-singleton-initialization from e3213370aa to 33ebf0302b

2021-10-16 08:32:51 +02:00

Compare

kske merged commit 866a547114 into develop

2021-10-16 08:33:08 +02:00

kske deleted branch f/static-singleton-initialization

2021-10-16 08:33:08 +02:00

kske referenced this issue from a commit

2021-10-16 08:33:09 +02:00

Merge pull request 'Initialize the Default Event Bus Statically' (#23) from f/static-singleton-initialization into develop

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zdm/event-bus#23