zdm/event-bus
3
Fork 0
Code Issues 2 Pull Requests Releases 8 Wiki Activity

Add Event Cancellation #3

Merged
kske merged 6 commits from f/cancel-event into develop 2020-11-26 08:57:46 +01:00
Conversation 1 Commits 6 Files Changed 5 +178 -50
kske commented 2020-11-25 08:38:21 +01:00
Owner
Copy Link

EventBus can now cancel an event that is currently being dispatched from one of its event handlers. This means, that it will not be dispatched to any more handlers with a lower priority.

Note that cancelling events is only supported from an active dispatching thread and an EventBusException will be thrown otherwise.

Additionally, EventBusTest has been split up into DispatchTest and CancelTest for simplicity's sake.

`EventBus` can now cancel an event that is currently being dispatched from one of its event handlers. This means, that it will not be dispatched to any more handlers with a lower priority. Note that cancelling events is only supported from an active dispatching thread and an `EventBusException` will be thrown otherwise. Additionally, `EventBusTest` has been split up into `DispatchTest` and `CancelTest` for simplicity's sake.
kske self-assigned this 2020-11-25 08:38:21 +01:00
kske requested review from delvh 2020-11-26 08:14:42 +01:00
delvh commented 2020-11-26 08:35:48 +01:00
Owner
Copy Link

👍

:+1:
kske merged commit 748cb8b71a into develop 2020-11-26 08:57:46 +01:00
kske deleted branch f/cancel-event 2020-11-26 08:57:52 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
delvh
Labels
Clear labels
1
1
13
13
2
2
21
21
3
3
34
34
5
5
55
55
8
8
bug
Something isn't working
core
Event Bus Core
could have
This doesn't hurt
duplicate
This issue or pull request already exists
enhancement
New feature or request
help wanted
Extra attention is needed
must have
This is absolutely necessary
proc
Event Bus Proc
question
Further information is needed
should have
This should be implemented
wont have
This won't be implemented (for now)
L
Branches where 300 < X <= 600 lines are added and more than one work day is needed
M
Branches where 100 < X <=300 lines are added
S
Branches where X <= 100 lines are added or less than 30 minutes are needed
XL
Branch where X > 600 lines are added and more than two work days are needed
bug
Something is not working
bugfix
Fixes a bug
discussion
This has to be discussed
documentation
Related to documentation
feature
Introduces a new feature
maintenance
Related to project maintenance
postponed
Won't be done in the immediate future
refactoring
Refactoring code or architectures
wontfix
Will not be fixed in this state of development
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
delvh kske mpk
No Assignees kske
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zdm/event-bus#3
No description provided.
Delete Branch "f/cancel-event"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?