zdm/event-bus
zdm
/
event-bus
3
Fork 0
Code Issues 2 Pull Requests Releases 8 Wiki Activity

Add Callback Event Handling #26

Merged
kske merged 3 commits from f/callback-handler into develop 2021-11-05 08:49:07 +01:00
Conversation 0 Commits 3 Files Changed 7 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c614beb063 - Show all commits

2
event-bus-core/src/main/java/dev/kske/eventbus/core/handler/CallbackEventHandler.java
View File

@ -9,7 +9,7 @@ import java.util.function.Consumer;
* @author Kai S. K. Engelbart
* @since 1.2.0
*/
public class CallbackEventHandler implements EventHandler {
public final class CallbackEventHandler implements EventHandler {
kske marked this conversation as resolved Outdated
delvh commented 2021-11-04 14:21:39 +01:00
Outdated
Review
Copy Link

final?

final?
private final Class<?> eventType;
private final Consumer<Object> callback;
delvh marked this conversation as resolved
delvh commented 2021-11-04 14:25:20 +01:00
Review
Copy Link

What about Consumer ?

What about Consumer<?> ?
kske commented 2021-11-04 15:50:49 +01:00
Review
Copy Link

This wouldn't work, as `callback.accept(event)' would complain about an incompatible argument type.

This wouldn't work, as `callback.accept(event)' would complain about an incompatible argument type.