zdm/undo-redo
Archived
3
Fork 0
Code Issues 2 Pull Requests Releases 1 Activity

JavaFX Integration #4

Merged
kske merged 4 commits from f/javafx into develop 2021-12-16 12:05:50 +01:00
Conversation 0 Commits 4 Files Changed 11 +99
6 changed files with 99 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d49772a127 - Show all commits

27
javafx/.classpath Normal file
View File

@ -0,0 +1,27 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
<classpathentry kind="src" output="target/classes" path="src/main/java">
<attributes>
<attribute name="optional" value="true"/>
<attribute name="maven.pomderived" value="true"/>
</attributes>
</classpathentry>
<classpathentry kind="src" output="target/test-classes" path="src/test/java">
<attributes>
<attribute name="optional" value="true"/>
<attribute name="maven.pomderived" value="true"/>
<attribute name="test" value="true"/>
</attributes>
</classpathentry>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11">
<attributes>
<attribute name="maven.pomderived" value="true"/>
</attributes>
</classpathentry>
<classpathentry kind="con" path="org.eclipse.m2e.MAVEN2_CLASSPATH_CONTAINER">
<attributes>
<attribute name="maven.pomderived" value="true"/>
</attributes>
</classpathentry>
<classpathentry kind="output" path="target/classes"/>
</classpath>

23
javafx/.project Normal file
View File

@ -0,0 +1,23 @@
<?xml version="1.0" encoding="UTF-8"?>
<projectDescription>
<name>undo-redo-javafx</name>
<comment></comment>
<projects>
</projects>
<buildSpec>
<buildCommand>
<name>org.eclipse.jdt.core.javabuilder</name>
<arguments>
</arguments>
</buildCommand>
<buildCommand>
<name>org.eclipse.m2e.core.maven2Builder</name>
<arguments>
</arguments>
</buildCommand>
</buildSpec>
<natures>
<nature>org.eclipse.jdt.core.javanature</nature>
<nature>org.eclipse.m2e.core.maven2Nature</nature>
</natures>
</projectDescription>

28
javafx/pom.xml Normal file
View File

@ -0,0 +1,28 @@
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<artifactId>javafx</artifactId>
<name>Undo-Redo JavaFX Integration</name>
<parent>
<groupId>dev.kske</groupId>
<artifactId>undo-redo</artifactId>
<version>0.0.1-SNAPSHOT</version>
</parent>
<dependencies>
<dependency>
<groupId>dev.kske</groupId>
<artifactId>undo-redo-core</artifactId>
<version>0.0.1-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.openjfx</groupId>
<artifactId>javafx-base</artifactId>
<version>11</version>
delvh commented 2021-12-14 21:33:28 +01:00
Review
Copy Link

Shouldn't it be provided?

Otherwise we run into version problems...

Shouldn't it be `provided`? Otherwise we run into version problems...
kske commented 2021-12-15 15:05:27 +01:00
Review
Copy Link

A project using this library should be able to use any JavaFX version >= 11. A fixed version would be defined like this: [11]. <scope>provided</scope> assumes that the dependency is present in some kind of runtime container, like the JDK or a Java EE container, which isn't the case here.

A project using this library should be able to use any JavaFX version >= 11. A fixed version would be defined like this: `[11]`. `<scope>provided</scope>` assumes that the dependency is present in some kind of runtime container, like the JDK or a Java EE container, which isn't the case here.
delvh commented 2021-12-15 15:19:37 +01:00
Review
Copy Link

I thought that was exactly the goal behind provided: To declare that any version of JavaFX is possible, as long as it is present...

I thought that was exactly the goal behind `provided`: To declare that any version of JavaFX is possible, as long as it is present...
kske commented 2021-12-16 10:06:17 +01:00
Review
Copy Link

I don't think the scope has anything to do with the version: https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope

There is a possibility to specify version ranger, but the default should be sufficient for us: https://docs.oracle.com/middleware/1212/core/MAVEN/maven_version.htm#MAVEN402

I don't think the scope has anything to do with the version: https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope There is a possibility to specify version ranger, but the default should be sufficient for us: https://docs.oracle.com/middleware/1212/core/MAVEN/maven_version.htm#MAVEN402
</dependency>
</dependencies>
</project>

7
javafx/src/main/java/dev/kske/undoredo/javafx/package-info.java Normal file
View File

@ -0,0 +1,7 @@
/**
* Contains JavaFX-based wrapper API for integrating Undo-Redo with JavaFX.
*
* @author Kai S. K. Engelbart
* @since 0.0.1
*/
package dev.kske.undoredo.javafx;

13
javafx/src/main/java/module-info.java Normal file
View File

@ -0,0 +1,13 @@
/**
* Contains JavaFX-based wrapper API for integrating Undo-Redo with JavaFX.
*
* @author Kai S. K. Engelbart
* @since 0.0.1
*/
module dev.kske.undoredo.javafx {
exports dev.kske.undoredo.javafx;
requires dev.kske.undoredo.core;
requires javafx.base;
}

1
pom.xml
View File

@ -14,6 +14,7 @@
<modules> <modules>
<module>core</module> <module>core</module>
<module>javafx</module>
</modules> </modules>
<licenses> <licenses>