Kai S. K. Engelbart kske
  • Joined on 2020-08-15
kske pushed to b/divergent-history at zdm/undo-redo 2021-12-22 15:32:32 +01:00
1155541350 Fix javafx module artifact name
kske deleted branch f/javafx from zdm/undo-redo 2021-12-16 12:05:51 +01:00
kske pushed to develop at zdm/undo-redo 2021-12-16 12:05:51 +01:00
fa5c2419bf Merge pull request 'JavaFX Integration' (#4) from f/javafx into develop
0f1c3e06d8 JavaFX reflective access + Javadoc + @delvh
1b6d7f3dde Add ObservableChangeManager interface with wrapper implementation
d49772a127 Add javafx module
d80dd94e90 Allow retrieving the last change from a change manager
Compare 5 commits »
kske closed issue zdm/undo-redo#3 2021-12-16 12:05:50 +01:00
JavaFX Integration
kske merged pull request zdm/undo-redo#4 2021-12-16 12:05:50 +01:00
JavaFX Integration
kske pushed to f/javafx at zdm/undo-redo 2021-12-16 10:22:40 +01:00
0f1c3e06d8 JavaFX reflective access + Javadoc + @delvh
kske commented on pull request zdm/undo-redo#4 2021-12-16 10:16:34 +01:00
JavaFX Integration

UndoFX might be more flexible in some cases (e.g. non-linear history and such), but for our and most other purposes this solution should be more than enough.

kske commented on pull request zdm/undo-redo#4 2021-12-16 10:06:17 +01:00
JavaFX Integration

I don't think the scope has anything to do with the version: https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope

There is a possibility to…

kske commented on pull request zdm/undo-redo#4 2021-12-15 15:27:38 +01:00
JavaFX Integration

But what purpose should this have? When would it be used?

kske commented on pull request zdm/undo-redo#4 2021-12-15 15:27:17 +01:00
JavaFX Integration

I would prefer having gaps of 10, or maybe 100, but with exponential gaps, the rule is unnecessarily complex and we can easily surpass Integer.MAX_VALUE / 2, which is the default order for JUnit…

kske commented on pull request zdm/undo-redo#4 2021-12-15 15:07:55 +01:00
JavaFX Integration

How would you deal with a class that has more than nine tests?

kske commented on pull request zdm/undo-redo#4 2021-12-15 15:05:27 +01:00
JavaFX Integration

A project using this library should be able to use any JavaFX version >= 11. A fixed version would be defined like this: [11]. <scope>provided</scope> assumes that the dependency is present in…

kske commented on pull request zdm/undo-redo#4 2021-12-15 15:03:53 +01:00
JavaFX Integration

You mean the string literal? So for every property that is declared we would declare another constant?

kske commented on pull request zdm/undo-redo#4 2021-12-15 15:03:17 +01:00
JavaFX Integration

I think the wrapper can be concrete, but should be open for extension in case we want a wrapper for a change manager with additional methods.

kske commented on pull request zdm/undo-redo#4 2021-12-15 15:02:22 +01:00
JavaFX Integration

We discussed this in #2. I think @DieGurke resolved the suggestion as we didn't reach a conclusion after stating our opinions.

kske commented on pull request zdm/undo-redo#4 2021-12-15 15:00:24 +01:00
JavaFX Integration

The core module doesn't have any dependencies, so this shouldn't make a difference.

kske created pull request zdm/undo-redo#4 2021-12-14 20:48:30 +01:00
JavaFX Integration
kske pushed to f/javafx at zdm/undo-redo 2021-12-12 08:07:05 +01:00
1b6d7f3dde Add ObservableChangeManager interface with wrapper implementation
kske pushed to f/javafx at zdm/undo-redo 2021-12-12 05:59:37 +01:00
d49772a127 Add javafx module
d80dd94e90 Allow retrieving the last change from a change manager
Compare 2 commits »
kske created branch f/javafx in zdm/undo-redo 2021-12-12 05:59:37 +01:00