Kai S. K. Engelbart kske
3 Followers · 4 Following
  • Joined on 2020-08-15
Repositories
7
 Projects Packages Public Activity Watched Repositories
kske 2021-12-08 10:39:32 +01:00
Reason:
I will implement my suggestions myself, as we were pair coding on this branch anyways.
kske pushed to f/basics at zdm/undo-redo 2021-12-08 10:35:19 +01:00
acb25c3120 Improve ChangeManager Javadoc
kske commented on pull request zdm/undo-redo#2 2021-12-07 21:22:04 +01:00
Basic API Structure

"whether an action was performed"

kske commented on pull request zdm/undo-redo#2 2021-12-07 21:22:04 +01:00
Basic API Structure

"whether a change is present that can be undone"

kske commented on pull request zdm/undo-redo#2 2021-12-07 21:22:04 +01:00
Basic API Structure

"whether a change is present that can be redone"

kske commented on pull request zdm/undo-redo#2 2021-12-07 21:22:04 +01:00
Basic API Structure

The main description of the class is missing. I suggest something along the lines of:

kske commented on pull request zdm/undo-redo#2 2021-12-07 21:22:04 +01:00
Basic API Structure

"Undoes the current change."

kske commented on pull request zdm/undo-redo#2 2021-12-07 21:22:04 +01:00
Basic API Structure

"whether an action was performed"

kske commented on pull request zdm/undo-redo#2 2021-12-07 21:22:04 +01:00
Basic API Structure

"Marks the current change."

kske commented on pull request zdm/undo-redo#2 2021-12-07 21:22:04 +01:00
Basic API Structure

Replace types by type, as the user only specifies one parameter.

kske commented on pull request zdm/undo-redo#2 2021-12-07 21:22:04 +01:00
Basic API Structure

"Applies the given change and appends it to the change list."

kske commented on pull request zdm/undo-redo#2 2021-12-07 21:22:04 +01:00
Basic API Structure

"whether the current change is marked"

kske suggested changes for zdm/undo-redo#2 2021-12-07 21:22:04 +01:00
Basic API Structure

Code looks good, the Javadoc can be a bit more clear in some places. What we are missing are unit tests. Every method in the change manager should be thoroughly tested in a unit test.

kske approved zdm/undo-redo#1 2021-12-07 18:08:42 +01:00
Project Setup

Off to a good start 👍

kske commented on issue zdm/envoy#100 2021-12-06 21:45:38 +01:00
Account Deletion

Yeah @delvh what's the matter?

kske merged pull request zdm/envoy#115 2021-12-04 09:22:54 +01:00
Update Default Chat Pictures on Theme Change
kske pushed to develop at zdm/envoy 2021-12-04 09:22:54 +01:00
6499a4f698 Merge pull request 'Update Default Chat Pictures on Theme Change' (#115) from b/ui-fixes into develop
05ed5da41b Merge branch 'develop' into b/ui-fixes
b653652f6d Fix chat default pictures not being updated on theme change
Compare 3 commits »
kske deleted branch b/ui-fixes from zdm/envoy 2021-12-04 09:22:54 +01:00
kske commented on pull request zdm/envoy#115 2021-12-04 09:22:45 +01:00
Update Default Chat Pictures on Theme Change

I was also very curious about that, but then I thought, why let it sit on some bugfix branch instead of merging it.

kske pushed to b/ui-fixes at zdm/envoy 2021-12-03 21:37:32 +01:00
05ed5da41b Merge branch 'develop' into b/ui-fixes
c5f4969666 Merge pull request 'Add Jenkinsfile' (#114) from feature/jenkinsfile into develop
1a9f9a85ab Add Jenkinsfile
544210a811 Merge pull request 'Upgrade to Event Bus 1.0.0' (#112) from event-bus-1.0.0 into develop
5ef5d96445 Upgrade to Event Bus 1.0.0
Compare 7 commits »