Server Sending Pending Messages Too Slow #106

New Issue

delvh · 2020-10-22T16:58:41+02:00

delvh commented

2020-10-22 16:58:41 +02:00

When the server has to send around 50 pending messages, the server sends them so slow that the client thinks he has disconnected in the meantime. It literally does that while still receiving messages. This means that under certain circumstances you'll be forever unable to log in with the server.

delvh added this to the v0.3-beta milestone 2020-10-22 16:58:41 +02:00

delvh added the

bug

M

server

labels 2020-10-22 16:58:41 +02:00

kske self-assigned this 2020-11-30 22:18:43 +01:00

kske referenced this issue from a commit

2020-11-30 22:31:20 +01:00

Send pending messages after successful handshake Instead of caching pending messages during the handshake and relaying them afterwards, they are now sent after the handshake has been completed. This is possible because the relevant processors (messages and status changes) are now event handlers which are registered at the event bus, which means that they can immediately react to pending messages even if Client#initReceiver has not been fully executed yet. Because Client#initReceiver exists for that very reason, it is now longer necessary. ID generator initialization, which was its other part, is now directly handled in Startup#performHandshake, which is a far more sensible placement. Fixes #106

kske referenced a pull request that will close this issue

2020-11-30 22:34:30 +01:00