Send Pending Messages After Successful Handshake #111

kske · 2020-11-30T22:34:30+01:00

kske commented

2020-11-30 22:34:30 +01:00

Instead of caching pending messages during the handshake and relaying
them afterwards, they are now sent after the handshake has been
completed.

This is possible because the relevant processors (messages and status
changes) are now event handlers which are registered at the event bus,
which means that they can immediately react to pending messages even if
Client#initReceiver has not been fully executed yet.

Because Client#initReceiver exists for that very reason, it is no
longer necessary anymore. ID generator initialization, which was its other part,
is now directly handled in Startup#performHandshake, which is a far more
sensible placement.

Fixes #106

Instead of caching pending messages during the handshake and relaying them afterwards, they are now sent after the handshake has been completed. This is possible because the relevant processors (messages and status changes) are now event handlers which are registered at the event bus, which means that they can immediately react to pending messages even if `Client#initReceiver` has not been fully executed yet. Because `Client#initReceiver` exists for that very reason, it is no longer necessary anymore. ID generator initialization, which was its other part, is now directly handled in `Startup#performHandshake`, which is a far more sensible placement. Fixes #106

kske added this to the v0.3-beta milestone 2020-11-30 22:34:30 +01:00

kske added the

labels 2020-11-30 22:34:30 +01:00

kske self-assigned this 2020-11-30 22:34:30 +01:00

kske requested review from delvh 2020-11-30 22:34:35 +01:00

kske requested review from mpk 2020-11-30 22:34:36 +01:00

mpk approved these changes 2020-12-01 21:13:44 +01:00

delvh commented