zdm/envoy
Archived
3
Fork 0
Code Issues 22 Pull Requests Releases 1 Wiki Activity

Refactoring #55

Merged
kske merged 7 commits from refactoring into develop 2020-09-27 12:06:39 +02:00
Conversation 1 Commits 7 Files Changed 140 +484 -1524
kske commented 2020-09-26 16:49:48 +02:00
Owner
Copy Link

Refactored large parts of the client:

  • Removed SendEvent in favor of direct access to Client
  • Removed most received object processors in favor of event handlers
  • Moved business logic from ChatScene to LocalDB
  • Make data structures in Chat and LocalDB observable to simplify UI refreshes
  • Remove Javadoc file headers

Closes #21

Refactored large parts of the client: * Removed `SendEvent` in favor of direct access to `Client` * Removed most received object processors in favor of event handlers * Moved business logic from `ChatScene` to `LocalDB` * Make data structures in `Chat` and `LocalDB` observable to simplify UI refreshes * Remove Javadoc file headers Closes #21
kske added this to the v0.2-beta milestone 2020-09-26 16:49:48 +02:00
kske added the
L
client
 labels 2020-09-26 16:49:48 +02:00
kske self-assigned this 2020-09-26 16:49:48 +02:00
kske requested review from delvh 2020-09-26 17:54:28 +02:00
kske requested review from mpk 2020-09-26 17:54:29 +02:00
kske added a new dependency 2020-09-26 18:13:13 +02:00
#53 Breaking IssueProposals
delvh approved these changes 2020-09-26 22:14:43 +02:00
delvh left a comment
Owner

👍

👍
client/src/main/java/envoy/client/ui/controller/ChatScene.java
@@ -269,0 +250,4 @@
// message
if (currentChat != null) localDB.getMessage(evt.getID())
.filter(msg -> msg.getSenderID() == client.getSender().getID())
.ifPresent(msg -> Platform.runLater(messageList::refresh));
delvh commented 2020-09-26 21:50:42 +02:00
Owner

Did you test this? Is the normal refresh enough?

Did you test this? Is the normal refresh enough?
kske commented 2020-09-27 12:02:16 +02:00
Author
Owner

Yes, it is, as the refresh method refreshed all objects inside the list that might have changed.

Yes, it is, as the `refresh` method refreshed all objects inside the list that might have changed.
kske marked this conversation as resolved
common/src/main/java/envoy/util/Bounds.java
@@ -3,12 +3,6 @@ package envoy.util;
import java.util.regex.Pattern;
/**
* Implements contact name validation.
delvh commented 2020-09-26 22:05:23 +02:00
Owner

Why has that been taken out?

Why has that been taken out?
kske marked this conversation as resolved
server/src/main/java/envoy/server/net/ObjectWriteProxy.java Outdated
@@ -68,7 +62,7 @@ public final class ObjectWriteProxy {
/**
* Sends an object to all contact in a set that are online.
delvh commented 2020-09-26 22:08:43 +02:00
Owner

contacts

contact***s***
kske marked this conversation as resolved
server/src/main/java/envoy/server/net/ObjectWriteProxy.java Outdated
@@ -77,7 +71,7 @@ public final class ObjectWriteProxy {
/**
* Sends an object to all contact in a set that are online.
delvh commented 2020-09-26 22:08:57 +02:00
Owner

contacts

contact***s***
kske marked this conversation as resolved
delvh added a new dependency 2020-09-26 23:13:53 +02:00
#58 Sanitized Issue Proposals
kske merged commit d1d52468bc into develop 2020-09-27 12:06:38 +02:00
kske deleted branch refactoring 2020-09-27 12:06:44 +02:00
delvh removed a dependency 2020-09-27 13:46:19 +02:00
#58 Sanitized Issue Proposals
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
mpk
delvh
Labels
Clear labels
client
Envoy Client
server
Envoy Server
user made
This issue has been created through Envoy
L
Branches where 300 < X <= 600 lines are added and more than one work day is needed
M
Branches where 100 < X <=300 lines are added
S
Branches where X <= 100 lines are added or less than 30 minutes are needed
XL
Branch where X > 600 lines are added and more than two work days are needed
bug
Something is not working
bugfix
Fixes a bug
discussion
This has to be discussed
documentation
Related to documentation
feature
Introduces a new feature
maintenance
Related to project maintenance
postponed
Won't be done in the immediate future
refactoring
Refactoring code or architectures
wontfix
Will not be fixed in this state of development
No Label
client
L
Milestone
No items
No Milestone v0.2-beta
Assignees
Clear assignees
delvh kske mpk
No Assignees kske
2 Participants
Due Date
No due date set.
Blocks
#53 Breaking IssueProposals
zdm/envoy
Reference: zdm/envoy#55
No description provided.
Delete Branch "refactoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?