Bump JavaFX Version to 15 to Support Emoji Fonts #72

kske · 2020-09-30T09:58:31+02:00

kske commented

2020-09-30 09:58:31 +02:00

When an emoji font is present on the system, emojis can be displayed perfectly fine in newer versions of JavaFX.

If no emoji font is installed, emojis are displayed as unknown characters instead of crashing the whole application.

Fixes #3

When an emoji font is present on the system, emojis can be displayed perfectly fine in newer versions of JavaFX. If no emoji font is installed, emojis are displayed as unknown characters instead of crashing the whole application. Fixes #3

kske added this to the v0.3-beta milestone 2020-09-30 09:58:31 +02:00

kske added the

bug

S

client

labels 2020-09-30 09:58:31 +02:00

kske self-assigned this 2020-09-30 09:58:31 +02:00

delvh commented

2020-09-30 10:08:51 +02:00

Does JavaFX 15 fix this?

kske commented

2020-09-30 10:13:26 +02:00

Does JavaFX 15 fix this?

Exactly.

> Does JavaFX 15 fix this? Exactly.

kske requested review from delvh 2020-09-30 10:14:04 +02:00

kske requested review from mpk 2020-09-30 10:14:04 +02:00

delvh commented

2020-09-30 10:37:15 +02:00

@kske

Does JavaFX 15 fix this?

Exactly.

Are there any other advantages JavaFX 15 has over JavaFX 11 we should know of?

@kske >> Does JavaFX 15 fix this? > >Exactly. Are there any other advantages JavaFX 15 has over JavaFX 11 we should know of?

kske commented

2020-09-30 10:53:14 +02:00

@kske

Does JavaFX 15 fix this?

Exactly.

Are there any other advantages JavaFX 15 has over JavaFX 11 we should know of?

None that I know of. You should be able to find the changelog on the internet.

> @kske > > >> Does JavaFX 15 fix this? > > > >Exactly. > > Are there any other advantages JavaFX 15 has over JavaFX 11 we should know of? None that I know of. You should be able to find the changelog on the internet.

delvh approved these changes 2020-09-30 12:49:56 +02:00

delvh left a comment

If it really works, I'll have no problem with that fix. That'd solve ahuge problem we face.
Let's give it a try.

If it really works, I'll have no problem with that fix. That'd solve ahuge problem we face. Let's give it a try.

kske added the due date 2020-10-01

2020-09-30 12:59:08 +02:00

mpk approved these changes 2020-09-30 18:26:20 +02:00

mpk left a comment

👍

kske referenced this issue from a commit

2020-09-30 18:41:31 +02:00

Bump JavaFX Version to 15 to Support Emoji Fonts (#72) Bump JavaFX version to 15 to support emoji fonts Reviewed-on: https://git.kske.dev/zdm/envoy/pulls/72 Reviewed-by: delvh <leon@kske.dev> Reviewed-by: DieGurke <maxi@kske.dev>