zdm/envoy
zdm/envoy
Archived
3
Fork 0
Code Issues 22 Pull Requests Releases 1 Wiki Activity

Bump JavaFX Version to 15 to Support Emoji Fonts #72

Merged
kske merged 1 commits from b/display-emoji into develop 2020-09-30 18:41:32 +02:00
Conversation 6 Commits 1 Files Changed 1 +2 -2
kske commented 2020-09-30 09:58:31 +02:00
Owner
Copy Link

When an emoji font is present on the system, emojis can be displayed perfectly fine in newer versions of JavaFX.

If no emoji font is installed, emojis are displayed as unknown characters instead of crashing the whole application.

Fixes #3

When an emoji font is present on the system, emojis can be displayed perfectly fine in newer versions of JavaFX. If no emoji font is installed, emojis are displayed as unknown characters instead of crashing the whole application. Fixes #3
kske added this to the v0.3-beta milestone 2020-09-30 09:58:31 +02:00
kske added the
bug
S
client
 labels 2020-09-30 09:58:31 +02:00
kske self-assigned this 2020-09-30 09:58:31 +02:00
delvh commented 2020-09-30 10:08:51 +02:00
Owner
Copy Link

Does JavaFX 15 fix this?

Does JavaFX 15 fix this?
kske commented 2020-09-30 10:13:26 +02:00
Author
Owner
Copy Link

Does JavaFX 15 fix this?

Exactly.

> Does JavaFX 15 fix this? Exactly.
kske requested review from delvh 2020-09-30 10:14:04 +02:00
kske requested review from mpk 2020-09-30 10:14:04 +02:00
delvh commented 2020-09-30 10:37:15 +02:00
Owner
Copy Link

@kske

Does JavaFX 15 fix this?

Exactly.

Are there any other advantages JavaFX 15 has over JavaFX 11 we should know of?

@kske >> Does JavaFX 15 fix this? > >Exactly. Are there any other advantages JavaFX 15 has over JavaFX 11 we should know of?
kske commented 2020-09-30 10:53:14 +02:00
Author
Owner
Copy Link

@kske

Does JavaFX 15 fix this?

Exactly.

Are there any other advantages JavaFX 15 has over JavaFX 11 we should know of?

None that I know of. You should be able to find the changelog on the internet.

> @kske > > >> Does JavaFX 15 fix this? > > > >Exactly. > > Are there any other advantages JavaFX 15 has over JavaFX 11 we should know of? None that I know of. You should be able to find the changelog on the internet.
delvh approved these changes 2020-09-30 12:49:56 +02:00
delvh left a comment
Owner

If it really works, I'll have no problem with that fix. That'd solve ahuge problem we face.
Let's give it a try.

If it really works, I'll have no problem with that fix. That'd solve ahuge problem we face. Let's give it a try.
kske added the due date 2020-10-01 2020-09-30 12:59:08 +02:00
mpk approved these changes 2020-09-30 18:26:20 +02:00
mpk left a comment
Owner

👍

👍
kske merged commit 2779971e99 into develop 2020-09-30 18:41:32 +02:00
kske deleted branch b/display-emoji 2020-09-30 18:41:39 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
delvh
mpk
Labels
Clear labels
client
Envoy Client
server
Envoy Server
user made
This issue has been created through Envoy
L
Branches where 300 < X <= 600 lines are added and more than one work day is needed
M
Branches where 100 < X <=300 lines are added
S
Branches where X <= 100 lines are added or less than 30 minutes are needed
XL
Branch where X > 600 lines are added and more than two work days are needed
bug
Something is not working
bugfix
Fixes a bug
discussion
This has to be discussed
documentation
Related to documentation
feature
Introduces a new feature
maintenance
Related to project maintenance
postponed
Won't be done in the immediate future
refactoring
Refactoring code or architectures
wontfix
Will not be fixed in this state of development
No Label
client
S
bug
Milestone
No items
No Milestone v0.3-beta
Assignees
Clear assignees
No Assignees kske
3 Participants
Due Date
2020-10-01
Dependencies

No dependencies set.

Reference: zdm/envoy#72
No description provided.
Delete Branch "b/display-emoji"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?