Improve Scene Switching #109

kske · 2020-11-20T14:14:11+01:00

kske commented

2020-11-20 14:14:11 +01:00

This pull request improves the scene switching mechanism implemented in SceneContext.

Instead of creating a new scene every time a scene change is triggered, the same scene is reused with another root node.

By adjusting the initial size of the scene to that of the stage, the stage is now resized during a scene change, resulting in a superior user experience.

Fixes #89

This pull request improves the scene switching mechanism implemented in `SceneContext`. Instead of creating a new scene every time a scene change is triggered, the same scene is reused with another root node. By adjusting the initial size of the scene to that of the stage, the stage is now resized during a scene change, resulting in a superior user experience. Fixes #89

kske added this to the v0.3-beta milestone 2020-11-20 14:14:11 +01:00

kske added the

bug

client

M

labels 2020-11-20 14:14:11 +01:00

kske self-assigned this 2020-11-20 14:14:11 +01:00

delvh approved these changes 2020-11-20 14:22:57 +01:00

delvh left a comment

👍 Seems fine

delvh commented

2020-11-21 20:30:09 +01:00

I like how you didn't even assign @DieGurke as a reviewer...

delvh added the due date 2020-11-22

2020-11-21 20:55:28 +01:00

delvh reviewed 2020-11-21 20:58:31 +01:00

client/src/main/java/envoy/client/ui/SceneContext.java

						
				@ -124,4 +89,0 @@

							applyCSS();

							stage.show();

						} catch (final IOException e) {

							EnvoyLog.getLogger(SceneContext.class).log(Level.SEVERE,