Add Image Caching #95

delvh · 2020-10-10T14:32:09+02:00

delvh commented

2020-10-10 14:32:09 +02:00

No description provided.

delvh added this to the v0.3-beta milestone 2020-10-10 14:32:09 +02:00

delvh added the

client

S

labels 2020-10-10 14:32:09 +02:00

delvh self-assigned this 2020-10-10 14:32:09 +02:00

delvh requested review from mpk 2020-10-10 14:32:28 +02:00

delvh requested review from kske 2020-10-10 14:32:29 +02:00

kske approved these changes 2020-10-12 15:09:16 +02:00

kske left a comment

There were two things I wanted to request changes for and then fixed by myself:

Using Map#computeIfAbsent instead of lengthy if statements.
Simplify the key for scaled icons, as the collision described inside the Javadoc is actually impossible.

There were two things I wanted to request changes for and then fixed by myself: 1. Using `Map#computeIfAbsent` instead of lengthy if statements. 2. Simplify the key for scaled icons, as the collision described inside the Javadoc is actually impossible.

mpk approved these changes 2020-10-13 09:14:53 +02:00

mpk left a comment

Looks good to me

kske referenced this issue from a commit

2020-10-13 11:30:19 +02:00

Add Image Caching (#95) Add image caching Co-authored-by: kske <kai@kske.dev> Reviewed-on: https://git.kske.dev/zdm/envoy/pulls/95 Reviewed-by: kske <kai@kske.dev> Reviewed-by: DieGurke <maxi@kske.dev>

kske merged commit ab2e9aa114 into develop

2020-10-13 11:30:19 +02:00

kske deleted branch f/image-cache

2020-10-13 11:30:25 +02:00

This repo is archived. You cannot comment on pull requests.

3 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zdm/envoy#95