zdm/event-bus
zdm/event-bus
3
Fork 0
Code Issues 2 Pull Requests Releases 8 Wiki Activity

Add ExceptionEvent #12

Merged
kske merged 2 commits from f/exception-event into develop 2021-02-21 14:04:26 +01:00
Conversation 2 Commits 2 Files Changed 6 +170 -12
kske commented 2021-02-21 12:10:38 +01:00
Owner
Copy Link

An exception event wraps an event that caused an exception inside of an
event handler while being dispatched and is then dispatched to dedicated
handlers.

Closes #11

An exception event wraps an event that caused an exception inside of an event handler while being dispatched and is then dispatched to dedicated handlers. Closes #11
kske added the
core
enhancement
 labels 2021-02-21 12:10:38 +01:00
kske self-assigned this 2021-02-21 12:10:38 +01:00
kske added 1 commit 2021-02-21 12:10:39 +01:00 
An exception event wraps an event that caused an exception inside of an
event handler while being dispatched and is then dispatched to dedicated
handlers.
kske requested review from delvh 2021-02-21 12:10:43 +01:00
kske requested review from mpk 2021-02-21 12:10:43 +01:00
delvh approved these changes 2021-02-21 12:30:52 +01:00
delvh left a comment
Owner
Copy Link

👍

👍
event-bus-core/src/main/java/dev/kske/eventbus/core/EventBus.java
@ -84,1 +86,3 @@
handlers.next().execute(event);
try {
handlers.next().execute(event);
} catch (InvocationTargetException e) {
delvh commented 2021-02-21 12:29:26 +01:00
Owner
Copy Link

Why only InvocationTargetException and not Throwable?

Why only `InvocationTargetException` and not `Throwable`?
kske commented 2021-02-21 12:34:12 +01:00
Author
Owner
Copy Link

Because the InvocationTargetException specifically wraps an exception thrown by the event handler, while the IllegalAccessException and IllegalArgumentException are only thrown in the case of an invalid configuration.

Because the `InvocationTargetException` specifically wraps an exception thrown by the event handler, while the `IllegalAccessException` and `IllegalArgumentException` are only thrown in the case of an invalid configuration.
kske added 1 commit 2021-02-21 13:51:21 +01:00
mpk approved these changes 2021-02-21 14:03:58 +01:00
kske merged commit d9ddc0e1a9 into develop 2021-02-21 14:04:26 +01:00
kske deleted branch f/exception-event 2021-02-21 14:04:32 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
delvh
mpk
Labels
Clear labels
1
1
13
13
2
2
21
21
3
3
34
34
5
5
55
55
8
8
bug
Something isn't working
core
Event Bus Core
could have
This doesn't hurt
duplicate
This issue or pull request already exists
enhancement
New feature or request
help wanted
Extra attention is needed
must have
This is absolutely necessary
proc
Event Bus Proc
question
Further information is needed
should have
This should be implemented
wont have
This won't be implemented (for now)
L
Branches where 300 < X <= 600 lines are added and more than one work day is needed
M
Branches where 100 < X <=300 lines are added
S
Branches where X <= 100 lines are added or less than 30 minutes are needed
XL
Branch where X > 600 lines are added and more than two work days are needed
bug
Something is not working
bugfix
Fixes a bug
discussion
This has to be discussed
documentation
Related to documentation
feature
Introduces a new feature
maintenance
Related to project maintenance
postponed
Won't be done in the immediate future
refactoring
Refactoring code or architectures
wontfix
Will not be fixed in this state of development
No Label
core
enhancement
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees kske
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zdm/event-bus#12
No description provided.
Delete Branch "f/exception-event"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?