Add ExceptionEvent #12

kske · 2021-02-21T12:10:38+01:00

kske commented

2021-02-21 12:10:38 +01:00

An exception event wraps an event that caused an exception inside of an
event handler while being dispatched and is then dispatched to dedicated
handlers.

Closes #11

An exception event wraps an event that caused an exception inside of an event handler while being dispatched and is then dispatched to dedicated handlers. Closes #11

kske added the

core

enhancement

labels 2021-02-21 12:10:38 +01:00

kske self-assigned this 2021-02-21 12:10:38 +01:00

kske added 1 commit 2021-02-21 12:10:39 +01:00

Add ExceptionEvent 6a2cad4ae5

An exception event wraps an event that caused an exception inside of an
event handler while being dispatched and is then dispatched to dedicated
handlers.

kske requested review from delvh 2021-02-21 12:10:43 +01:00

kske requested review from mpk 2021-02-21 12:10:43 +01:00

delvh approved these changes 2021-02-21 12:30:52 +01:00

delvh left a comment

👍

event-bus-core/src/main/java/dev/kske/eventbus/core/EventBus.java

						
				@ -84,1 +86,3 @@

									handlers.next().execute(event);

									try {

										handlers.next().execute(event);

									} catch (InvocationTargetException e) {

delvh commented

2021-02-21 12:29:26 +01:00

Why only InvocationTargetException and not Throwable?

Why only `InvocationTargetException` and not `Throwable`?

kske commented

2021-02-21 12:34:12 +01:00

Because the InvocationTargetException specifically wraps an exception thrown by the event handler, while the IllegalAccessException and IllegalArgumentException are only thrown in the case of an invalid configuration.

Because the `InvocationTargetException` specifically wraps an exception thrown by the event handler, while the `IllegalAccessException` and `IllegalArgumentException` are only thrown in the case of an invalid configuration.

kske added 1 commit 2021-02-21 13:51:21 +01:00

Add system events section to README 7c3cd017de

mpk approved these changes 2021-02-21 14:03:58 +01:00

kske merged commit d9ddc0e1a9 into develop

2021-02-21 14:04:26 +01:00

kske referenced this issue from a commit

2021-02-21 14:04:27 +01:00

Merge pull request 'Add ExceptionEvent' (#12) from f/exception-event into develop

kske deleted branch f/exception-event

2021-02-21 14:04:32 +01:00

Sign in to join this conversation.

No reviewers