Remove USE_PARAMETER #35
No reviewers
Labels
No Label
1
13
2
21
3
34
5
55
8
bug
core
could have
duplicate
enhancement
help wanted
must have
proc
question
should have
wont have
bug
bugfix
discussion
documentation
feature
L
M
maintenance
postponed
refactoring
S
wontfix
XL
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: zdm/event-bus#35
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "f/remove-use-parameter"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
Use
void.class
instead ofUSE_PARAMETER.class
which was introduced for reasons no longer present.Additionally, update the accessibility of reflective event handler methods only if that's actually necessary. That way, public handlers can be can be invoked reflectively without opening the containing module to Event Bus.
f/remove-use-parameterto Remove USE_PARAMETER@ -38,3 +37,3 @@
this.listener = listener;
this.method = method;
useParameter = annotation.value() == USE_PARAMETER.class;
useParameter = annotation.value() == void.class;
|| annotation.value == Void.class
That wouldn't be the default type though. Yes, using
Void
as an event type doesn't make much sense, but it is possible, which isn't the case forvoid
.