Remove USE_PARAMETER #35

kske · 2022-01-12T20:11:08+01:00

kske commented

2022-01-12 20:11:08 +01:00

Use void.class instead of USE_PARAMETER.class which was introduced for reasons no longer present.

Additionally, update the accessibility of reflective event handler methods only if that's actually necessary. That way, public handlers can be can be invoked reflectively without opening the containing module to Event Bus.

Use `void.class` instead of `USE_PARAMETER.class` which was introduced for reasons no longer present. Additionally, update the accessibility of reflective event handler methods only if that's actually necessary. That way, public handlers can be can be invoked reflectively without opening the containing module to Event Bus.

kske self-assigned this 2022-01-12 20:11:08 +01:00

kske added 3 commits 2022-01-12 20:11:08 +01:00

Use void.class to determine how the event handler type is defined

zdm/event-bus/pipeline/head There was a failure building this commit

Details

36ed55fd71

The dummy class USE_PARAMETER was necessary when the IEvent interface
still existed, as void.class could not be used as a Class<? extends
IEvent>. As no explicit reference to USE_PARAMETER should be present
anywhere, a proper deprecation would've made little sense.

Only update handler accessibility if necessary

zdm/event-bus/pipeline/head This commit looks good

Details

3aef7d5bcb

Fix Event Bus Proc module name

zdm/event-bus/pipeline/head There was a failure building this commit

Details

8615a0e021

kske requested review from delvh 2022-01-12 20:11:15 +01:00

kske changed title from ~~f/remove-use-parameter~~ to Remove USE_PARAMETER

2022-01-12 20:11:23 +01:00

kske added 1 commit 2022-01-12 20:17:27 +01:00

Fix inconsistent test

zdm/event-bus/pipeline/head This commit looks good

Details

6ee4e11161

delvh approved these changes 2022-01-13 14:37:08 +01:00

core/src/main/java/dev/kske/eventbus/core/handler/ReflectiveEventHandler.java

						
				@ -38,3 +37,3 @@

						this.listener	= listener;

						this.method		= method;

						useParameter	= annotation.value() == USE_PARAMETER.class;

						useParameter	= annotation.value() == void.class;

delvh commented

2022-01-13 13:39:24 +01:00

|| annotation.value == Void.class

`|| annotation.value == Void.class`

kske commented

2022-01-13 14:40:00 +01:00

That wouldn't be the default type though. Yes, using Void as an event type doesn't make much sense, but it is possible, which isn't the case for void.

That wouldn't be the default type though. Yes, using `Void` as an event type doesn't make much sense, but it is possible, which isn't the case for `void`.

👍 1

delvh marked this conversation as resolved

kske merged commit a8d858e8c7 into develop

2022-01-13 14:40:14 +01:00

kske deleted branch f/remove-use-parameter

2022-01-13 14:40:14 +01:00

kske referenced this issue from a commit

2022-01-13 14:40:14 +01:00

Merge pull request 'Remove USE_PARAMETER' (#35) from f/remove-use-parameter into develop

Sign in to join this conversation.