Remove USE_PARAMETER #35

Merged
kske merged 4 commits from f/remove-use-parameter into develop 2022-01-13 14:40:14 +01:00

Use void.class instead of USE_PARAMETER.class which was introduced for reasons no longer present.

Additionally, update the accessibility of reflective event handler methods only if that's actually necessary. That way, public handlers can be can be invoked reflectively without opening the containing module to Event Bus.

Use `void.class` instead of `USE_PARAMETER.class` which was introduced for reasons no longer present. Additionally, update the accessibility of reflective event handler methods only if that's actually necessary. That way, public handlers can be can be invoked reflectively without opening the containing module to Event Bus.
kske self-assigned this 2022-01-12 20:11:08 +01:00
kske added 3 commits 2022-01-12 20:11:08 +01:00
zdm/event-bus/pipeline/head There was a failure building this commit Details
36ed55fd71
Use void.class to determine how the event handler type is defined
The dummy class USE_PARAMETER was necessary when the IEvent interface
still existed, as void.class could not be used as a Class<? extends
IEvent>. As no explicit reference to USE_PARAMETER should be present
anywhere, a proper deprecation would've made little sense.
zdm/event-bus/pipeline/head This commit looks good Details
3aef7d5bcb
Only update handler accessibility if necessary
zdm/event-bus/pipeline/head There was a failure building this commit Details
8615a0e021
Fix Event Bus Proc module name
kske requested review from delvh 2022-01-12 20:11:15 +01:00
kske changed title from f/remove-use-parameter to Remove USE_PARAMETER 2022-01-12 20:11:23 +01:00
kske added 1 commit 2022-01-12 20:17:27 +01:00
zdm/event-bus/pipeline/head This commit looks good Details
6ee4e11161
Fix inconsistent test
delvh approved these changes 2022-01-13 14:37:08 +01:00
@ -38,3 +37,3 @@
this.listener = listener;
this.method = method;
useParameter = annotation.value() == USE_PARAMETER.class;
useParameter = annotation.value() == void.class;

|| annotation.value == Void.class

`|| annotation.value == Void.class`
Poster
Owner

That wouldn't be the default type though. Yes, using Void as an event type doesn't make much sense, but it is possible, which isn't the case for void.

That wouldn't be the default type though. Yes, using `Void` as an event type doesn't make much sense, but it is possible, which isn't the case for `void`.
delvh marked this conversation as resolved
kske merged commit a8d858e8c7 into develop 2022-01-13 14:40:14 +01:00
kske deleted branch f/remove-use-parameter 2022-01-13 14:40:14 +01:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: zdm/event-bus#35
There is no content yet.