zdm/event-bus
3
Fork 0
Code Issues 2 Pull Requests Releases 8 Wiki Activity

Remove USE_PARAMETER #35

Merged
kske merged 4 commits from f/remove-use-parameter into develop 2022-01-13 14:40:14 +01:00
Conversation 1 Commits 4 Files Changed 6 +13 -28
kske commented 2022-01-12 20:11:08 +01:00
Owner
Copy Link

Use void.class instead of USE_PARAMETER.class which was introduced for reasons no longer present.

Additionally, update the accessibility of reflective event handler methods only if that's actually necessary. That way, public handlers can be can be invoked reflectively without opening the containing module to Event Bus.

Use `void.class` instead of `USE_PARAMETER.class` which was introduced for reasons no longer present. Additionally, update the accessibility of reflective event handler methods only if that's actually necessary. That way, public handlers can be can be invoked reflectively without opening the containing module to Event Bus.
kske self-assigned this 2022-01-12 20:11:08 +01:00
kske added 3 commits 2022-01-12 20:11:08 +01:00
Use void.class to determine how the event handler type is defined
Some checks failed
zdm/event-bus/pipeline/head There was a failure building this commit
Details
36ed55fd71 
The dummy class USE_PARAMETER was necessary when the IEvent interface
still existed, as void.class could not be used as a Class<? extends
IEvent>. As no explicit reference to USE_PARAMETER should be present
anywhere, a proper deprecation would've made little sense.
Only update handler accessibility if necessary
All checks were successful
zdm/event-bus/pipeline/head This commit looks good
Details
3aef7d5bcb
Fix Event Bus Proc module name
Some checks failed
zdm/event-bus/pipeline/head There was a failure building this commit
Details
8615a0e021
kske requested review from delvh 2022-01-12 20:11:15 +01:00
kske changed title from f/remove-use-parameter to Remove USE_PARAMETER 2022-01-12 20:11:23 +01:00
kske added 1 commit 2022-01-12 20:17:27 +01:00
Fix inconsistent test
All checks were successful
zdm/event-bus/pipeline/head This commit looks good
Details
6ee4e11161
delvh approved these changes 2022-01-13 14:37:08 +01:00
core/src/main/java/dev/kske/eventbus/core/handler/ReflectiveEventHandler.java
@@ -38,3 +37,3 @@
this.listener = listener;
this.method = method;
useParameter = annotation.value() == USE_PARAMETER.class;
useParameter = annotation.value() == void.class;
delvh commented 2022-01-13 13:39:24 +01:00
Owner
Copy Link

|| annotation.value == Void.class

`|| annotation.value == Void.class`
kske commented 2022-01-13 14:40:00 +01:00
Author
Owner
Copy Link

That wouldn't be the default type though. Yes, using Void as an event type doesn't make much sense, but it is possible, which isn't the case for void.

That wouldn't be the default type though. Yes, using `Void` as an event type doesn't make much sense, but it is possible, which isn't the case for `void`.
👍 1
delvh marked this conversation as resolved
kske merged commit a8d858e8c7 into develop 2022-01-13 14:40:14 +01:00
kske deleted branch f/remove-use-parameter 2022-01-13 14:40:14 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
delvh
Labels
Clear labels
1
1
13
13
2
2
21
21
3
3
34
34
5
5
55
55
8
8
bug
Something isn't working
core
Event Bus Core
could have
This doesn't hurt
duplicate
This issue or pull request already exists
enhancement
New feature or request
help wanted
Extra attention is needed
must have
This is absolutely necessary
proc
Event Bus Proc
question
Further information is needed
should have
This should be implemented
wont have
This won't be implemented (for now)
L
Branches where 300 < X <= 600 lines are added and more than one work day is needed
M
Branches where 100 < X <=300 lines are added
S
Branches where X <= 100 lines are added or less than 30 minutes are needed
XL
Branch where X > 600 lines are added and more than two work days are needed
bug
Something is not working
bugfix
Fixes a bug
discussion
This has to be discussed
documentation
Related to documentation
feature
Introduces a new feature
maintenance
Related to project maintenance
postponed
Won't be done in the immediate future
refactoring
Refactoring code or architectures
wontfix
Will not be fixed in this state of development
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
delvh kske mpk
No Assignees kske
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zdm/event-bus#35
No description provided.
Delete Branch "f/remove-use-parameter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?