Transparently Propagate Event Handler Errors #14

kske · 2021-03-15T08:36:05+01:00

kske commented

2021-03-15 08:36:05 +01:00

When an exception occurs during the execution of an event handler, it is
caught, wrapped inside an exception event and dispatched on the event
bus.

This applies to any throwable, but is not very useful for errors, as
these are not normally caught. Assertion errors in particular, which are
used in unit tests, should not be caught, as this would cause the test
runner to miss a failed test.

Therefore, errors are now transparently passed through to the caller of
the dispatch method.

When an exception occurs during the execution of an event handler, it is caught, wrapped inside an exception event and dispatched on the event bus. This applies to any throwable, but is not very useful for errors, as these are not normally caught. Assertion errors in particular, which are used in unit tests, should not be caught, as this would cause the test runner to miss a failed test. Therefore, errors are now transparently passed through to the caller of the dispatch method.

kske added the

bug

core

should have

labels 2021-03-15 08:36:05 +01:00

kske self-assigned this 2021-03-15 08:36:05 +01:00

kske added 1 commit 2021-03-15 08:36:05 +01:00

Transparently propagate event handler errors 122106bf39

When an exception occurs during the execution of an event handler, it is
caught, wrapped inside an exception event and dispatched on the event
bus.

This applies to any throwable, but is not very useful for errors, as
these are not normally caught. Assertion errors in particular, which are
used in unit tests, should not be caught, as this would cause the test
runner to miss a failed test.

Therefore, errors are now transparently passed through to the caller of
the dispatch method.

kske requested review from delvh 2021-03-15 08:36:09 +01:00

kske requested review from mpk 2021-03-15 08:36:09 +01:00

delvh approved these changes 2021-03-15 09:07:10 +01:00

delvh left a comment

👍

mpk approved these changes 2021-03-15 17:52:18 +01:00

mpk left a comment

What a hell lof of a change

kske merged commit 52719d22d4 into develop

2021-03-16 08:17:42 +01:00

kske referenced this issue from a commit

2021-03-16 08:17:43 +01:00