zdm/event-bus
zdm/event-bus
3
Fork 0
Code Issues 2 Pull Requests Releases 8 Wiki Activity

Shorten Module Names #30

Merged
kske merged 1 commits from f/improve-project-structure into develop 2021-12-24 13:57:17 +01:00
Conversation 1 Commits 1 Files Changed 31 +2 -2
kske commented 2021-12-24 10:13:04 +01:00
Owner
Copy Link

The artifact IDs remain the same, but the module names don't contain the prefix event-bus- anymore.

The artifact IDs remain the same, but the module names don't contain the prefix `event-bus-` anymore.
kske self-assigned this 2021-12-24 10:13:04 +01:00
kske added 1 commit 2021-12-24 10:13:04 +01:00
kske requested review from delvh 2021-12-24 10:13:08 +01:00
delvh approved these changes 2021-12-24 13:19:09 +01:00
pom.xml
@ -13,8 +13,8 @@
<url>https://git.kske.dev/kske/event-bus</url>
<modules>
<module>event-bus-core</module>
delvh commented 2021-12-24 13:18:59 +01:00
Owner
Copy Link

Am I right to assume that you can (still) call the modules using

<dependency>
	<groupId>dev.kske</groupId>
    <artifactId>event-bus-$MODULE_NAME</artifactId>
</dependency>

or do I see that incorrectly?

Am I right to assume that you can (still) call the modules using ```xml <dependency> <groupId>dev.kske</groupId> <artifactId>event-bus-$MODULE_NAME</artifactId> </dependency> ``` or do I see that incorrectly?
kske commented 2021-12-24 13:57:02 +01:00
Author
Owner
Copy Link

Exactly. The artifact IDs stay the same. It is only the module name (and therefore the directory) that has changed.

Exactly. The artifact IDs stay the same. It is only the module name (and therefore the directory) that has changed.
kske merged commit d649f377b7 into develop 2021-12-24 13:57:17 +01:00
kske deleted branch f/improve-project-structure 2021-12-24 13:57:17 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
delvh
Labels
Clear labels
1
1
13
13
2
2
21
21
3
3
34
34
5
5
55
55
8
8
bug
Something isn't working
core
Event Bus Core
could have
This doesn't hurt
duplicate
This issue or pull request already exists
enhancement
New feature or request
help wanted
Extra attention is needed
must have
This is absolutely necessary
proc
Event Bus Proc
question
Further information is needed
should have
This should be implemented
wont have
This won't be implemented (for now)
L
Branches where 300 < X <= 600 lines are added and more than one work day is needed
M
Branches where 100 < X <=300 lines are added
S
Branches where X <= 100 lines are added or less than 30 minutes are needed
XL
Branch where X > 600 lines are added and more than two work days are needed
bug
Something is not working
bugfix
Fixes a bug
discussion
This has to be discussed
documentation
Related to documentation
feature
Introduces a new feature
maintenance
Related to project maintenance
postponed
Won't be done in the immediate future
refactoring
Refactoring code or architectures
wontfix
Will not be fixed in this state of development
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees kske
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zdm/event-bus#30
No description provided.
Delete Branch "f/improve-project-structure"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?