Handler Caching #37

Merged

kske merged 5 commits from f/handler-caching into develop

kske commented

Owner

Closes #20

kske self-assigned this

kske requested review from delvh

delvh approved these changes

core/src/main/java/dev/kske/eventbus/core/EventBus.java Outdated

													
				@ -405,0 +435,4 @@

							var it = binding.iterator();

							while (it.hasNext()) {

								var handler = it.next();

								if (handler.getListener() == listener) {

delvh commented

Owner

Maybe add a comment on why == instead of equals.

Maybe add a comment on why `==` instead of `equals`.

kske commented

Poster

Owner

As we implicitly test using equals in registerListener(...), I will change this as well.

As we implicitly test using `equals` in `registerListener(...)`, I will change this as well.

kske marked this conversation as resolved

core/src/test/java/dev/kske/eventbus/core/DispatchTest.java

													
				@ -67,0 +71,4 @@

					@Test

					void testBindingCache() {

						String executionOrder = bus.debugExecutionOrder(SimpleEventSub.class);

						System.out.println(executionOrder);