Handler Caching #37

Merged
kske merged 5 commits from f/handler-caching into develop 1 year ago
kske commented 1 year ago
Owner

Closes #20

Closes #20
kske self-assigned this 1 year ago
kske added 2 commits 1 year ago
zdm/event-bus/pipeline/head This commit looks good Details
5468bddb35
Add handler cache
The cache has the same structure as the bindings and is updated
accordingly. To ensure the correctness and efficiency of the cache, more
testing has to be conducted.
zdm/event-bus/pipeline/head This commit looks good Details
ee9d08b2b8
Test binding cache
kske requested review from delvh 1 year ago
kske added 1 commit 1 year ago
zdm/event-bus/pipeline/head This commit looks good Details
8609c6a90c
Simplify binding cache usage
delvh approved these changes 1 year ago
@ -405,0 +435,4 @@
var it = binding.iterator();
while (it.hasNext()) {
var handler = it.next();
if (handler.getListener() == listener) {
delvh commented 1 year ago
Owner

Maybe add a comment on why == instead of equals.

Maybe add a comment on why `==` instead of `equals`.
kske commented 1 year ago
Poster
Owner

As we implicitly test using equals in registerListener(...), I will change this as well.

As we implicitly test using `equals` in `registerListener(...)`, I will change this as well.
kske marked this conversation as resolved
@ -67,0 +71,4 @@
@Test
void testBindingCache() {
String executionOrder = bus.debugExecutionOrder(SimpleEventSub.class);
System.out.println(executionOrder);
delvh commented 1 year ago
Owner

Why?

Why?
kske marked this conversation as resolved
kske added 1 commit 1 year ago
kske added 1 commit 1 year ago
zdm/event-bus/pipeline/head This commit looks good Details
8fae4f6d76
Remove print statements from test
kske merged commit cc5c07079a into develop 1 year ago
kske deleted branch f/handler-caching 1 year ago

Reviewers

delvh approved these changes 1 year ago
zdm/event-bus/pipeline/head This commit looks good
The pull request has been merged as cc5c07079a.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: zdm/event-bus#37
Loading…
There is no content yet.