zdm/event-bus
zdm/event-bus
3
Fork 0
Code Issues 2 Pull Requests Releases 8 Wiki Activity

Handler Caching #37

Merged
kske merged 5 commits from f/handler-caching into develop 2022-01-18 17:11:38 +01:00
Conversation 0 Commits 5 Files Changed 3 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2d276a1d74 - Show all commits

4
core/src/main/java/dev/kske/eventbus/core/EventBus.java
View File

@ -423,7 +423,7 @@ public final class EventBus {
var it = binding.iterator(); var it = binding.iterator();
while (it.hasNext()) { while (it.hasNext()) {
var handler = it.next(); var handler = it.next();
if (handler.getListener() == listener) { if (handler.getListener().equals(listener)) {
logger.log(Level.DEBUG, "Unbinding event handler {0}", handler); logger.log(Level.DEBUG, "Unbinding event handler {0}", handler);
it.remove(); it.remove();
} }
@ -435,7 +435,7 @@ public final class EventBus {
var it = binding.iterator(); var it = binding.iterator();
while (it.hasNext()) { while (it.hasNext()) {
var handler = it.next(); var handler = it.next();
if (handler.getListener() == listener) { if (handler.getListener().equals(listener)) {
kske marked this conversation as resolved Outdated
delvh commented 2022-01-18 16:06:37 +01:00
Outdated
Review
Copy Link

Maybe add a comment on why == instead of equals.

Maybe add a comment on why `==` instead of `equals`.
kske commented 2022-01-18 17:07:02 +01:00
Outdated
Review
Copy Link

As we implicitly test using equals in registerListener(...), I will change this as well.

As we implicitly test using `equals` in `registerListener(...)`, I will change this as well.
logger.log(Level.TRACE, "Removing event handler {0} from cache", handler); logger.log(Level.TRACE, "Removing event handler {0} from cache", handler);
it.remove(); it.remove();
} }