Additional Warnings in Event Bus Proc #8

kske · 2021-02-20T21:20:42+01:00

kske commented

2021-02-20 21:20:42 +01:00

Warn about unused return values and unnecessary / missing @Polymorphic annotations.

Closes #6

Warn about unused return values and unnecessary / missing `@Polymorphic` annotations. Closes #6

kske added the

enhancement

label 2021-02-20 21:20:42 +01:00

kske self-assigned this 2021-02-20 21:20:42 +01:00

kske added 2 commits 2021-02-20 21:20:43 +01:00

Warn about unnecessarily polymorphic event handlers b56f08e441

When Event Bus Proc detects a handler for a final type that uses the
@Polymorphic annotation, it issues a warning.

Warn about unused event handler return values 8a30493c52

If an event handler has a non-void return type, a warning is issued as
the event bus cannot use the returned value.

In rare cases this might be justified as the event handler could be
invoked directly.

kske requested review from delvh 2021-02-20 21:21:28 +01:00

kske added the due date 2021-02-21

2021-02-20 21:21:52 +01:00

kske requested review from mpk 2021-02-20 21:24:53 +01:00

delvh approved these changes 2021-02-20 21:33:38 +01:00

delvh left a comment

👍

kske removed review request for mpk 2021-02-20 21:46:01 +01:00

kske merged commit 9379e6bb94 into develop

2021-02-20 21:46:08 +01:00

kske referenced this issue from a commit

2021-02-20 21:46:08 +01:00

Merge pull request 'Additional Warnings in Event Bus Proc' (#8) from f/additional-warnings into develop

kske deleted branch f/additional-warnings

2021-02-20 21:46:12 +01:00

kske added the

proc

label 2021-02-20 22:20:49 +01:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2021-02-21

Dependencies

No dependencies set.

Reference: zdm/event-bus#8