zdm/undo-redo
Archived
3
Fork 0
Code Issues 2 Pull Requests Releases 1 Activity

Fix ChangeManagerWrapper #8

Merged
kske merged 1 commits from b/javafx-wrapper-properties into develop 2021-12-25 20:14:54 +00:00
Conversation 2 Commits 1 Files Changed 2 +2 -1
kske commented 2021-12-25 19:59:37 +00:00
Owner
Copy Link

The properties were in an inconsistent state after creation.

The properties were in an inconsistent state after creation.
kske self-assigned this 2021-12-25 19:59:37 +00:00
kske added 1 commit 2021-12-25 19:59:38 +00:00
Update properties on wrapper creation, fix NPE
All checks were successful
zdm/undo-redo/pipeline/head This commit looks good
Details
7101523584
kske requested review from delvh 2021-12-25 19:59:43 +00:00
kske requested review from mpk 2021-12-25 19:59:43 +00:00
mpk approved these changes 2021-12-25 20:01:34 +00:00
delvh approved these changes 2021-12-25 20:14:41 +00:00
kske merged commit ae2f2e8a84 into develop 2021-12-25 20:14:54 +00:00
kske deleted branch b/javafx-wrapper-properties 2021-12-25 20:14:54 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
mpk
delvh
Labels
Clear labels
1
1
 13
13
 2
2
 21
21
 3
3
 34
34
 5
5
 55
55
 8
8
 bug
Something isn't working
 could have
This doesn't hurt
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 help wanted
Extra attention is needed
 must have
This is absolutely necessary
 question
Further information is requested
 should have
This should be implemented
 stale
This issue or pull request had no recent activity
 wont have
This won't be implemented (for now)
L
Branches where 300 < X <= 600 lines are added and more than one work day is needed
 M
Branches where 100 < X <=300 lines are added
 S
Branches where X <= 100 lines are added or less than 30 minutes are needed
 XL
Branch where X > 600 lines are added and more than two work days are needed
 bug
Something is not working
 bugfix
Fixes a bug
 discussion
This has to be discussed
 documentation
Related to documentation
 feature
Introduces a new feature
 maintenance
Related to project maintenance
 postponed
Won't be done in the immediate future
 refactoring
Refactoring code or architectures
 wontfix
Will not be fixed in this state of development
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
delvh kske mpk
No Assignees kske
3 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zdm/undo-redo#8
Delete Branch "b/javafx-wrapper-properties"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?